Add ignoreInterpolations util to fourslash for fuzzy diagnostic matching
#35652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
reviewed
Dec 12, 2019
weswigham
reviewed
Dec 12, 2019
weswigham
reviewed
Dec 13, 2019
|
@weswigham I’m going to merge so I can rebase the PR I split this off from, but let me know if you have more feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: working on #32901 to stop returning a fix-all when there’s nothing left to fix led me to discover some fourslash codefix tests that seemed to be using
verify.codeFixAllinstead ofverify.codeFixpurely to avoid having to write out an interpolated diagnostic message fordescription. Writing the interpolation is often redundant with the rest of the test, and it makes it hard to use a constant fromts.Diagnostics.I wanted to put this functionality in a separate PR because I’m not 100% confident when or if the #32901 PR will land since I’ll need to coordinate with VS Code.