Ensure shared flow nodes are cached #41408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
For Uncommitted Bug
Flow nodes that optionally provide a flow type will delegate to their antecedent to determine a flow type using a loop in `getFlowTypeOfReference`. If these nodes are marked as shared then their result should be cached for future lookups, but the registration inside `getFlowTypeOfReference` did only consider the most-recently processed flow node. Any flow nodes up to that point that did not provide a type but were marked as shared would therefore not be cached at all. This commit keeps track of the first seen shared flow node and ensures that the result type is cached for that node.
JoostK
force-pushed
the
shared-flow-node-caching
branch
from
57bb716
to
3cc2032
Compare
|
@JoostK First, thanks for diagnosing this issue. You are indeed right, we end up not caching in cases where flow nodes are skipped and that's not a good thing. In terms of a fix, I think it can be even simpler than this PR. I will put up an alternative PR and run the full suite of tests on it. |
|
Closing as resolved in #41665. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41124
Alternative to #41387.
Flow nodes that optionally provide a flow type will delegate to their antecedent
to determine a flow type using a loop in
getFlowTypeOfReference. If these nodesare marked as shared then their result should be cached for future lookups, but
the registration inside
getFlowTypeOfReferencedid only consider the most-recentlyprocessed flow node. Any flow nodes up to that point that did not provide a type
but were marked as shared would therefore not be cached at all.
This commit keeps track of the first seen shared flow node and ensures that the
result type is cached for that node.