Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Pick PR #41479 (Add missed resolveSymbol in comm...) into release-4.1 #41691

Merged

Conversation

andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Nov 25, 2020

Beep boop I’m @typescript-bot
This cherry-pick was not triggered by a request on #41479 because I’m snoozin’ on the job.
Please review the diff and merge if no changes are unexpected.
You cannot view the cherry-pick log.

cc @andrewbranch

Fixes resolution of export aliases in the postfix-property-access case
of commonjs require:

```js
const { x } = require('./foo').nested
x
```

This program would previously fail if `x` was an export alias.

Fixes microsoft#41422
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug labels Nov 25, 2020
@sandersn sandersn added this to Not started in PR Backlog Dec 2, 2020
@sandersn sandersn moved this from Not started to Needs merge in PR Backlog Dec 2, 2020
@sandersn
Copy link
Member

@sandersn sandersn commented Dec 2, 2020

@andrewbranch is this ready to merge?

@andrewbranch
Copy link
Member Author

@andrewbranch andrewbranch commented Dec 2, 2020

👍 (attn: @DanielRosenwasser)

@andrewbranch andrewbranch merged commit 9b66258 into microsoft:release-4.1 Dec 2, 2020
10 checks passed
PR Backlog automation moved this from Needs merge to Done Dec 2, 2020
@andrewbranch andrewbranch deleted the pick/41479/release-4.1 branch Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug
Projects
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants