Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addImplementationSuccessElaboration admits declarations with no symbol #41758

Merged

Conversation

weswigham
Copy link
Member

@weswigham weswigham commented Dec 1, 2020

shakes fist Our imprecise type of Declaration.symbol leads to a bug yet again!

Fixes #41616

@weswigham weswigham requested review from sandersn and andrewbranch Dec 1, 2020
@typescript-bot typescript-bot added Author: Team For Milestone Bug labels Dec 1, 2020
@weswigham
Copy link
Member Author

@weswigham weswigham commented Dec 1, 2020

Github actions seems to be having some internal errors and builds are cancelling/rescheduling, but devops is reporting green, so I'll merge. Based on the associated issue's milestone, I'll also ask @typescript-bot cherry-pick this into release-4.1

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Dec 1, 2020

Heya @weswigham, I've started to run the task to cherry-pick this into release-4.1 on this PR at 0d61b14. You can monitor the build here.

@weswigham weswigham merged commit 2a3f550 into microsoft:master Dec 1, 2020
6 of 12 checks passed
@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Dec 1, 2020

Hey @weswigham, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.1 manually.

@weswigham
Copy link
Member Author

@weswigham weswigham commented Dec 7, 2020

@typescript-bot cherry-pick this into release-4.1

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Dec 7, 2020

Heya @weswigham, I've started to run the task to cherry-pick this into release-4.1 on this PR at 0d61b14. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Dec 7, 2020

Hey @weswigham, I've opened #41862 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue Dec 7, 2020
Component commits:
0d61b14 addImplementationSuccessElaboration admits declarations with no symbol
DanielRosenwasser pushed a commit that referenced this issue Dec 9, 2020
Component commits:
0d61b14 addImplementationSuccessElaboration admits declarations with no symbol

Co-authored-by: Wesley Wigham <t-weswig@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants