Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose EncodedSemanticClassificationsRequest in protocol.d.ts #42965

Merged
merged 1 commit into from Feb 25, 2021

Conversation

@orta
Copy link
Member

@orta orta commented Feb 25, 2021

Replicates #42640 for 4.2

* Expose EncodedSemanticClassificationsRequest in protocol.d.ts

* Adds the response for encoded semantic highlights too

* Update types:

* Also include classificationtype anyway

* Fix feedback
@orta orta added this to the TypeScript 4.2.2 milestone Feb 25, 2021
@orta orta self-assigned this Feb 25, 2021
@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Feb 25, 2021

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

@orta
Copy link
Member Author

@orta orta commented Feb 25, 2021

Thanks folks

@orta orta merged commit acc5fa0 into microsoft:release-4.2 Feb 25, 2021
9 checks passed
9 checks passed
@github-actions
build (10.x)
Details
@github-actions
CodeQL-Build CodeQL-Build
Details
@github-actions
build (12.x)
Details
@github-actions
build (14.x)
Details
@github-code-scanning
CodeQL No new or fixed alerts
Details
@microsoft-cla
license/cla All CLA requirements met.
Details
@azure-pipelines
node10 Build #96991 succeeded
Details
@azure-pipelines
node12 Build #96989 succeeded
Details
@azure-pipelines
node14 Build #96990 succeeded
Details
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants