Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only issue matching token errors on non-dupe locations #43460

Merged
merged 4 commits into from Mar 31, 2021

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Mar 31, 2021

Instead of unconditionally retrieving the last error and attaching a related span, parseErrorAt and friends now return the last error and
return false when there is none.

Also make one more place use parseExpectedMatchingBrackets that I missed last time.

Previously open questions:

  1. Does returning a value slowdown parseErrorAt and friends?
  2. Would returning Diagnostic | undefined be faster than Diagnostic | false?
  3. Would it slow down parseExpected to delegate to parseTokenForError and convert the return to boolean?

Answers:

  1. No.
  2. No, but it reads better, so I did.
  3. I decided to inline parseTokenForError, so this is moot.

Fixes comment on #40884.

Intead of unconditionally retrieving the last error and attaching a
related span, `parseErrorAt` and friends now return the last error and
return `false` when there is none.

Also make one more place use parseExpectedMatchingBrackets that I missed
last time.
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 31, 2021
@sandersn
Copy link
Member Author

sandersn commented Mar 31, 2021

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 31, 2021

Heya @sandersn, I've started to run the perf test suite on this PR at c141447. You can monitor the build here.

Update: The results are in!

@sandersn
Copy link
Member Author

sandersn commented Mar 31, 2021

Re 2: it reads less strangely to use undefined, so I'm going to do that.
Re 3: parseTokenForError is only called once and is like 4 lines, so I inlined it.

@sandersn
Copy link
Member Author

sandersn commented Mar 31, 2021

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 31, 2021

Heya @sandersn, I've started to run the perf test suite on this PR at 435c99d. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 31, 2021

@sandersn
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..43460

Metric master 43460 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,993k (± 0.02%) 344,924k (± 0.03%) -69k (- 0.02%) 344,677k 345,125k
Parse Time 1.93s (± 0.42%) 1.93s (± 0.60%) -0.01s (- 0.31%) 1.90s 1.95s
Bind Time 0.83s (± 0.98%) 0.83s (± 0.99%) +0.00s (+ 0.12%) 0.81s 0.85s
Check Time 5.09s (± 0.32%) 5.08s (± 0.68%) -0.01s (- 0.20%) 5.02s 5.18s
Emit Time 5.91s (± 0.39%) 5.91s (± 0.57%) -0.00s (- 0.05%) 5.87s 6.01s
Total Time 13.77s (± 0.26%) 13.75s (± 0.47%) -0.02s (- 0.12%) 13.65s 13.93s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,205k (± 0.04%) 203,272k (± 0.03%) +67k (+ 0.03%) 203,134k 203,444k
Parse Time 0.78s (± 0.43%) 0.79s (± 0.38%) +0.01s (+ 1.03%) 0.78s 0.79s
Bind Time 0.52s (± 0.91%) 0.52s (± 1.00%) -0.00s (- 0.76%) 0.51s 0.53s
Check Time 7.45s (± 0.61%) 7.44s (± 0.47%) -0.01s (- 0.16%) 7.37s 7.51s
Emit Time 2.56s (± 0.96%) 2.58s (± 0.87%) +0.02s (+ 0.62%) 2.54s 2.64s
Total Time 11.32s (± 0.57%) 11.32s (± 0.38%) +0.01s (+ 0.06%) 11.23s 11.40s
Monaco - node (v10.16.3, x64)
Memory used 342,677k (± 0.02%) 342,738k (± 0.04%) +61k (+ 0.02%) 342,527k 343,159k
Parse Time 1.56s (± 0.73%) 1.56s (± 0.48%) -0.00s (- 0.06%) 1.54s 1.57s
Bind Time 0.74s (± 0.70%) 0.74s (± 0.79%) -0.00s (- 0.27%) 0.73s 0.75s
Check Time 5.28s (± 0.58%) 5.26s (± 0.58%) -0.02s (- 0.36%) 5.19s 5.32s
Emit Time 3.13s (± 0.71%) 3.12s (± 0.71%) -0.01s (- 0.48%) 3.06s 3.18s
Total Time 10.71s (± 0.32%) 10.67s (± 0.44%) -0.04s (- 0.35%) 10.58s 10.81s
TFS - node (v10.16.3, x64)
Memory used 304,255k (± 0.01%) 304,453k (± 0.10%) +197k (+ 0.06%) 304,181k 305,697k
Parse Time 1.21s (± 0.75%) 1.22s (± 0.49%) +0.00s (+ 0.33%) 1.21s 1.23s
Bind Time 0.70s (± 0.53%) 0.70s (± 0.88%) -0.00s (- 0.57%) 0.69s 0.72s
Check Time 4.74s (± 0.61%) 4.74s (± 0.44%) +0.00s (+ 0.08%) 4.69s 4.78s
Emit Time 3.27s (± 0.73%) 3.23s (± 1.04%) -0.04s (- 1.31%) 3.18s 3.30s
Total Time 9.93s (± 0.41%) 9.89s (± 0.49%) -0.04s (- 0.38%) 9.78s 9.97s
material-ui - node (v10.16.3, x64)
Memory used 465,431k (± 0.02%) 465,350k (± 0.01%) -81k (- 0.02%) 465,182k 465,503k
Parse Time 2.01s (± 0.60%) 2.00s (± 0.34%) -0.01s (- 0.25%) 1.99s 2.02s
Bind Time 0.66s (± 1.13%) 0.66s (± 1.13%) +0.00s (+ 0.45%) 0.64s 0.68s
Check Time 14.20s (± 0.25%) 14.26s (± 0.36%) +0.06s (+ 0.41%) 14.16s 14.36s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.87s (± 0.21%) 16.93s (± 0.33%) +0.06s (+ 0.33%) 16.83s 17.05s
Angular - node (v12.1.0, x64)
Memory used 322,616k (± 0.04%) 322,770k (± 0.03%) +154k (+ 0.05%) 322,574k 322,972k
Parse Time 1.92s (± 0.65%) 1.92s (± 0.71%) 0.00s ( 0.00%) 1.89s 1.95s
Bind Time 0.82s (± 0.73%) 0.81s (± 0.55%) -0.00s (- 0.37%) 0.80s 0.82s
Check Time 5.01s (± 0.35%) 5.00s (± 0.34%) -0.00s (- 0.10%) 4.97s 5.04s
Emit Time 6.00s (± 0.65%) 5.95s (± 0.53%) -0.05s (- 0.78%) 5.90s 6.04s
Total Time 13.74s (± 0.40%) 13.69s (± 0.27%) -0.05s (- 0.36%) 13.59s 13.76s
Compiler-Unions - node (v12.1.0, x64)
Memory used 190,323k (± 0.25%) 190,156k (± 0.16%) -167k (- 0.09%) 189,175k 190,815k
Parse Time 0.77s (± 0.89%) 0.77s (± 0.64%) -0.00s (- 0.00%) 0.76s 0.78s
Bind Time 0.52s (± 0.65%) 0.53s (± 0.76%) +0.01s (+ 1.15%) 0.52s 0.54s
Check Time 6.96s (± 0.55%) 6.94s (± 0.32%) -0.03s (- 0.36%) 6.89s 6.98s
Emit Time 2.54s (± 0.98%) 2.55s (± 0.94%) +0.01s (+ 0.28%) 2.50s 2.60s
Total Time 10.79s (± 0.51%) 10.78s (± 0.19%) -0.01s (- 0.12%) 10.71s 10.81s
Monaco - node (v12.1.0, x64)
Memory used 325,051k (± 0.02%) 325,063k (± 0.02%) +12k (+ 0.00%) 324,961k 325,243k
Parse Time 1.54s (± 0.76%) 1.53s (± 0.82%) -0.00s (- 0.26%) 1.50s 1.56s
Bind Time 0.72s (± 0.90%) 0.72s (± 0.86%) -0.00s (- 0.14%) 0.71s 0.74s
Check Time 5.10s (± 0.40%) 5.10s (± 0.42%) -0.00s (- 0.08%) 5.04s 5.14s
Emit Time 3.11s (± 0.69%) 3.10s (± 0.59%) -0.01s (- 0.39%) 3.07s 3.16s
Total Time 10.46s (± 0.32%) 10.44s (± 0.28%) -0.02s (- 0.18%) 10.38s 10.50s
TFS - node (v12.1.0, x64)
Memory used 288,777k (± 0.02%) 288,722k (± 0.02%) -55k (- 0.02%) 288,631k 288,953k
Parse Time 1.22s (± 0.49%) 1.21s (± 0.86%) -0.00s (- 0.33%) 1.19s 1.23s
Bind Time 0.69s (± 0.94%) 0.69s (± 0.83%) -0.00s (- 0.29%) 0.68s 0.71s
Check Time 4.66s (± 0.60%) 4.64s (± 0.72%) -0.01s (- 0.30%) 4.58s 4.70s
Emit Time 3.17s (± 0.74%) 3.16s (± 0.57%) -0.01s (- 0.19%) 3.12s 3.21s
Total Time 9.73s (± 0.55%) 9.71s (± 0.41%) -0.02s (- 0.25%) 9.62s 9.81s
material-ui - node (v12.1.0, x64)
Memory used 443,565k (± 0.01%) 443,613k (± 0.02%) +48k (+ 0.01%) 443,383k 443,836k
Parse Time 2.03s (± 0.39%) 2.03s (± 0.71%) -0.00s (- 0.20%) 2.00s 2.06s
Bind Time 0.64s (± 0.81%) 0.64s (± 1.09%) +0.00s (+ 0.31%) 0.63s 0.66s
Check Time 12.90s (± 0.55%) 12.92s (± 1.11%) +0.02s (+ 0.16%) 12.73s 13.43s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.57s (± 0.45%) 15.59s (± 0.93%) +0.02s (+ 0.14%) 15.40s 16.10s
Angular - node (v14.15.1, x64)
Memory used 321,377k (± 0.01%) 321,373k (± 0.01%) -4k (- 0.00%) 321,262k 321,417k
Parse Time 1.93s (± 0.58%) 1.93s (± 0.52%) +0.01s (+ 0.52%) 1.92s 1.96s
Bind Time 0.87s (± 0.92%) 0.86s (± 0.67%) -0.01s (- 0.92%) 0.85s 0.87s
Check Time 5.01s (± 0.49%) 5.03s (± 0.63%) +0.02s (+ 0.36%) 4.96s 5.11s
Emit Time 6.32s (± 0.27%) 6.29s (± 0.63%) -0.03s (- 0.52%) 6.21s 6.39s
Total Time 14.12s (± 0.33%) 14.11s (± 0.49%) -0.01s (- 0.08%) 14.01s 14.32s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,417k (± 0.01%) 189,411k (± 0.01%) -6k (- 0.00%) 189,342k 189,457k
Parse Time 0.80s (± 0.65%) 0.80s (± 0.50%) 0.00s ( 0.00%) 0.79s 0.81s
Bind Time 0.56s (± 0.80%) 0.56s (± 1.39%) +0.00s (+ 0.18%) 0.55s 0.58s
Check Time 7.07s (± 0.48%) 7.05s (± 0.41%) -0.02s (- 0.30%) 6.97s 7.12s
Emit Time 2.55s (± 0.99%) 2.55s (± 0.67%) +0.00s (+ 0.04%) 2.51s 2.58s
Total Time 10.98s (± 0.44%) 10.96s (± 0.29%) -0.02s (- 0.15%) 10.86s 11.03s
Monaco - node (v14.15.1, x64)
Memory used 324,058k (± 0.01%) 324,062k (± 0.01%) +4k (+ 0.00%) 323,986k 324,114k
Parse Time 1.57s (± 0.63%) 1.56s (± 0.57%) -0.01s (- 0.83%) 1.54s 1.58s
Bind Time 0.75s (± 0.50%) 0.75s (± 0.89%) +0.00s (+ 0.27%) 0.74s 0.77s
Check Time 5.05s (± 0.59%) 5.06s (± 0.42%) +0.01s (+ 0.28%) 5.02s 5.11s
Emit Time 3.18s (± 0.61%) 3.18s (± 0.47%) +0.00s (+ 0.06%) 3.16s 3.22s
Total Time 10.54s (± 0.38%) 10.54s (± 0.30%) +0.00s (+ 0.02%) 10.47s 10.60s
TFS - node (v14.15.1, x64)
Memory used 287,681k (± 0.01%) 287,691k (± 0.01%) +10k (+ 0.00%) 287,657k 287,729k
Parse Time 1.26s (± 1.44%) 1.27s (± 1.64%) +0.00s (+ 0.32%) 1.24s 1.34s
Bind Time 0.72s (± 1.46%) 0.72s (± 0.77%) -0.00s (- 0.28%) 0.71s 0.73s
Check Time 4.69s (± 0.36%) 4.67s (± 0.32%) -0.01s (- 0.28%) 4.64s 4.72s
Emit Time 3.26s (± 0.79%) 3.26s (± 0.79%) -0.00s (- 0.03%) 3.21s 3.33s
Total Time 9.93s (± 0.32%) 9.92s (± 0.32%) -0.01s (- 0.10%) 9.85s 9.99s
material-ui - node (v14.15.1, x64)
Memory used 441,693k (± 0.06%) 441,835k (± 0.00%) +142k (+ 0.03%) 441,789k 441,885k
Parse Time 2.08s (± 0.56%) 2.09s (± 0.60%) +0.01s (+ 0.43%) 2.07s 2.12s
Bind Time 0.69s (± 0.75%) 0.70s (± 0.83%) +0.01s (+ 1.16%) 0.68s 0.71s
Check Time 13.05s (± 0.89%) 13.00s (± 0.81%) -0.05s (- 0.39%) 12.84s 13.27s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.82s (± 0.77%) 15.79s (± 0.70%) -0.04s (- 0.23%) 15.60s 16.06s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory10 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 43460 10
Baseline master 10

Developer Information:

Download Benchmark

@sandersn
Copy link
Member Author

sandersn commented Mar 31, 2021

First perf run shows no difference

return false;
if (token() === closeKind) {
nextToken();
return true;
Copy link
Member

@DanielRosenwasser DanielRosenwasser Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like no part of the parser consumes the return value, so you can make this void-returning.

Copy link
Member Author

@sandersn sandersn Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it looks like it was just matching the nearby boolean functions.

@@ -39,7 +39,6 @@ tests/cases/conformance/es6/destructuring/destructuringParameterDeclaration2.ts(
!!! error TS2322: Type 'string' is not assignable to type 'number'.
~
!!! error TS1005: ',' expected.
!!! related TS1007 tests/cases/conformance/es6/destructuring/destructuringParameterDeclaration2.ts:7:4: The parser expected to find a ']' to match the '[' token here.
Copy link
Member

@DanielRosenwasser DanielRosenwasser Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why'd we lose this one?

Copy link
Member Author

@sandersn sandersn Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both , and ] were expected, but , got there first, so the ] error didn't get issued. With return value in hand, the code now skips issuing a [] related span on a , error.

Copy link
Member

@sheetalkamat sheetalkamat Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create separate issue for reporting error like expected , or ] instead.

Copy link
Member Author

@sandersn sandersn Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea: #43467

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 31, 2021

@sandersn
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..43460

Metric master 43460 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,993k (± 0.02%) 344,940k (± 0.02%) -53k (- 0.02%) 344,751k 345,100k
Parse Time 1.93s (± 0.42%) 1.94s (± 0.65%) +0.01s (+ 0.31%) 1.92s 1.97s
Bind Time 0.83s (± 0.98%) 0.83s (± 0.59%) +0.00s (+ 0.12%) 0.83s 0.85s
Check Time 5.09s (± 0.32%) 5.13s (± 0.41%) +0.03s (+ 0.69%) 5.07s 5.15s
Emit Time 5.91s (± 0.39%) 5.93s (± 0.51%) +0.02s (+ 0.34%) 5.87s 6.01s
Total Time 13.77s (± 0.26%) 13.84s (± 0.33%) +0.07s (+ 0.47%) 13.70s 13.92s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,205k (± 0.04%) 203,253k (± 0.05%) +48k (+ 0.02%) 203,077k 203,502k
Parse Time 0.78s (± 0.43%) 0.78s (± 0.51%) +0.00s (+ 0.13%) 0.77s 0.79s
Bind Time 0.52s (± 0.91%) 0.52s (± 0.91%) 0.00s ( 0.00%) 0.51s 0.53s
Check Time 7.45s (± 0.61%) 7.47s (± 0.45%) +0.02s (+ 0.20%) 7.41s 7.55s
Emit Time 2.56s (± 0.96%) 2.56s (± 0.90%) -0.00s (- 0.04%) 2.51s 2.63s
Total Time 11.32s (± 0.57%) 11.33s (± 0.46%) +0.02s (+ 0.14%) 11.26s 11.49s
Monaco - node (v10.16.3, x64)
Memory used 342,677k (± 0.02%) 342,694k (± 0.02%) +17k (+ 0.01%) 342,572k 342,879k
Parse Time 1.56s (± 0.73%) 1.56s (± 0.92%) 0.00s ( 0.00%) 1.52s 1.58s
Bind Time 0.74s (± 0.70%) 0.74s (± 0.75%) +0.00s (+ 0.41%) 0.73s 0.76s
Check Time 5.28s (± 0.58%) 5.26s (± 0.61%) -0.02s (- 0.42%) 5.18s 5.33s
Emit Time 3.13s (± 0.71%) 3.13s (± 0.78%) -0.00s (- 0.16%) 3.07s 3.19s
Total Time 10.71s (± 0.32%) 10.68s (± 0.45%) -0.03s (- 0.23%) 10.61s 10.82s
TFS - node (v10.16.3, x64)
Memory used 304,255k (± 0.01%) 304,273k (± 0.01%) +18k (+ 0.01%) 304,173k 304,331k
Parse Time 1.21s (± 0.75%) 1.21s (± 0.68%) +0.00s (+ 0.25%) 1.20s 1.24s
Bind Time 0.70s (± 0.53%) 0.70s (± 0.63%) -0.00s (- 0.43%) 0.69s 0.71s
Check Time 4.74s (± 0.61%) 4.75s (± 0.37%) +0.01s (+ 0.17%) 4.72s 4.80s
Emit Time 3.27s (± 0.73%) 3.26s (± 0.90%) -0.02s (- 0.52%) 3.17s 3.30s
Total Time 9.93s (± 0.41%) 9.93s (± 0.39%) -0.00s (- 0.04%) 9.83s 10.01s
material-ui - node (v10.16.3, x64)
Memory used 465,431k (± 0.02%) 465,339k (± 0.02%) -92k (- 0.02%) 465,148k 465,464k
Parse Time 2.01s (± 0.60%) 2.00s (± 0.41%) -0.01s (- 0.35%) 1.99s 2.02s
Bind Time 0.66s (± 1.13%) 0.66s (± 1.25%) +0.00s (+ 0.61%) 0.65s 0.68s
Check Time 14.20s (± 0.25%) 14.27s (± 0.57%) +0.07s (+ 0.48%) 14.12s 14.47s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.87s (± 0.21%) 16.93s (± 0.48%) +0.06s (+ 0.37%) 16.79s 17.12s
Angular - node (v12.1.0, x64)
Memory used 322,616k (± 0.04%) 322,676k (± 0.02%) +60k (+ 0.02%) 322,499k 322,901k
Parse Time 1.92s (± 0.65%) 1.93s (± 0.52%) +0.01s (+ 0.31%) 1.90s 1.94s
Bind Time 0.82s (± 0.73%) 0.81s (± 0.71%) -0.00s (- 0.61%) 0.80s 0.83s
Check Time 5.01s (± 0.35%) 5.00s (± 0.29%) -0.01s (- 0.22%) 4.96s 5.03s
Emit Time 6.00s (± 0.65%) 5.99s (± 0.40%) -0.01s (- 0.17%) 5.94s 6.04s
Total Time 13.74s (± 0.40%) 13.72s (± 0.21%) -0.02s (- 0.12%) 13.66s 13.78s
Compiler-Unions - node (v12.1.0, x64)
Memory used 190,323k (± 0.25%) 190,306k (± 0.14%) -17k (- 0.01%) 189,683k 190,862k
Parse Time 0.77s (± 0.89%) 0.77s (± 0.52%) +0.00s (+ 0.65%) 0.76s 0.78s
Bind Time 0.52s (± 0.65%) 0.53s (± 0.69%) +0.00s (+ 0.57%) 0.52s 0.53s
Check Time 6.96s (± 0.55%) 6.97s (± 0.39%) +0.01s (+ 0.16%) 6.92s 7.04s
Emit Time 2.54s (± 0.98%) 2.55s (± 0.75%) +0.01s (+ 0.31%) 2.50s 2.58s
Total Time 10.79s (± 0.51%) 10.82s (± 0.34%) +0.03s (+ 0.23%) 10.73s 10.90s
Monaco - node (v12.1.0, x64)
Memory used 325,051k (± 0.02%) 325,044k (± 0.02%) -7k (- 0.00%) 324,917k 325,168k
Parse Time 1.54s (± 0.76%) 1.54s (± 0.68%) +0.00s (+ 0.20%) 1.52s 1.56s
Bind Time 0.72s (± 0.90%) 0.72s (± 0.72%) -0.00s (- 0.14%) 0.71s 0.73s
Check Time 5.10s (± 0.40%) 5.10s (± 0.53%) -0.00s (- 0.02%) 5.04s 5.17s
Emit Time 3.11s (± 0.69%) 3.11s (± 0.71%) -0.00s (- 0.03%) 3.07s 3.15s
Total Time 10.46s (± 0.32%) 10.46s (± 0.41%) -0.00s (- 0.02%) 10.38s 10.54s
TFS - node (v12.1.0, x64)
Memory used 288,777k (± 0.02%) 288,796k (± 0.02%) +20k (+ 0.01%) 288,637k 288,898k
Parse Time 1.22s (± 0.49%) 1.21s (± 0.97%) -0.01s (- 0.41%) 1.19s 1.24s
Bind Time 0.69s (± 0.94%) 0.69s (± 0.64%) 0.00s ( 0.00%) 0.68s 0.70s
Check Time 4.66s (± 0.60%) 4.66s (± 0.36%) 0.00s ( 0.00%) 4.62s 4.71s
Emit Time 3.17s (± 0.74%) 3.15s (± 0.76%) -0.02s (- 0.73%) 3.10s 3.19s
Total Time 9.73s (± 0.55%) 9.71s (± 0.40%) -0.03s (- 0.27%) 9.63s 9.80s
material-ui - node (v12.1.0, x64)
Memory used 443,565k (± 0.01%) 443,553k (± 0.01%) -13k (- 0.00%) 443,398k 443,622k
Parse Time 2.03s (± 0.39%) 2.03s (± 0.46%) -0.00s (- 0.25%) 2.01s 2.05s
Bind Time 0.64s (± 0.81%) 0.64s (± 0.90%) +0.00s (+ 0.16%) 0.63s 0.65s
Check Time 12.90s (± 0.55%) 12.85s (± 0.54%) -0.05s (- 0.38%) 12.74s 13.02s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.57s (± 0.45%) 15.51s (± 0.46%) -0.06s (- 0.35%) 15.39s 15.70s
Angular - node (v14.15.1, x64)
Memory used 321,377k (± 0.01%) 321,376k (± 0.01%) -1k (- 0.00%) 321,337k 321,431k
Parse Time 1.93s (± 0.58%) 1.93s (± 0.45%) +0.00s (+ 0.16%) 1.91s 1.95s
Bind Time 0.87s (± 0.92%) 0.86s (± 0.72%) -0.01s (- 0.81%) 0.85s 0.88s
Check Time 5.01s (± 0.49%) 5.04s (± 0.37%) +0.03s (+ 0.50%) 5.00s 5.07s
Emit Time 6.32s (± 0.27%) 6.31s (± 0.66%) -0.00s (- 0.06%) 6.24s 6.46s
Total Time 14.12s (± 0.33%) 14.14s (± 0.35%) +0.02s (+ 0.12%) 14.07s 14.30s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,417k (± 0.01%) 189,410k (± 0.01%) -7k (- 0.00%) 189,339k 189,490k
Parse Time 0.80s (± 0.65%) 0.80s (± 0.37%) -0.00s (- 0.13%) 0.79s 0.80s
Bind Time 0.56s (± 0.80%) 0.56s (± 0.80%) +0.00s (+ 0.00%) 0.55s 0.57s
Check Time 7.07s (± 0.48%) 7.04s (± 0.45%) -0.03s (- 0.45%) 6.95s 7.10s
Emit Time 2.55s (± 0.99%) 2.56s (± 0.45%) +0.01s (+ 0.27%) 2.53s 2.58s
Total Time 10.98s (± 0.44%) 10.95s (± 0.33%) -0.03s (- 0.24%) 10.85s 11.02s
Monaco - node (v14.15.1, x64)
Memory used 324,058k (± 0.01%) 324,052k (± 0.01%) -6k (- 0.00%) 324,007k 324,096k
Parse Time 1.57s (± 0.63%) 1.57s (± 0.86%) -0.00s (- 0.06%) 1.54s 1.60s
Bind Time 0.75s (± 0.50%) 0.74s (± 0.80%) -0.00s (- 0.13%) 0.73s 0.76s
Check Time 5.05s (± 0.59%) 5.04s (± 0.51%) -0.01s (- 0.14%) 4.97s 5.10s
Emit Time 3.18s (± 0.61%) 3.17s (± 0.57%) -0.00s (- 0.09%) 3.14s 3.22s
Total Time 10.54s (± 0.38%) 10.53s (± 0.38%) -0.01s (- 0.11%) 10.43s 10.61s
TFS - node (v14.15.1, x64)
Memory used 287,681k (± 0.01%) 287,638k (± 0.01%) -44k (- 0.02%) 287,568k 287,682k
Parse Time 1.26s (± 1.44%) 1.25s (± 0.65%) -0.01s (- 0.71%) 1.24s 1.27s
Bind Time 0.72s (± 1.46%) 0.72s (± 0.90%) -0.00s (- 0.28%) 0.70s 0.73s
Check Time 4.69s (± 0.36%) 4.68s (± 0.57%) -0.00s (- 0.09%) 4.64s 4.77s
Emit Time 3.26s (± 0.79%) 3.27s (± 0.74%) +0.01s (+ 0.28%) 3.22s 3.34s
Total Time 9.93s (± 0.32%) 9.92s (± 0.53%) -0.01s (- 0.09%) 9.84s 10.09s
material-ui - node (v14.15.1, x64)
Memory used 441,693k (± 0.06%) 441,858k (± 0.00%) +165k (+ 0.04%) 441,818k 441,892k
Parse Time 2.08s (± 0.56%) 2.10s (± 0.48%) +0.01s (+ 0.48%) 2.08s 2.13s
Bind Time 0.69s (± 0.75%) 0.69s (± 0.69%) +0.00s (+ 0.58%) 0.68s 0.70s
Check Time 13.05s (± 0.89%) 12.94s (± 0.31%) -0.10s (- 0.80%) 12.87s 13.03s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.82s (± 0.77%) 15.73s (± 0.29%) -0.09s (- 0.58%) 15.64s 15.86s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory10 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 43460 10
Baseline master 10

Developer Information:

Download Benchmark

@sandersn sandersn merged commit 76a2ae3 into master Mar 31, 2021
10 checks passed
@sandersn sandersn deleted the only-matching-token-error-without-dupes branch Mar 31, 2021
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Apr 1, 2021

Thank you!

jessetrinity added a commit to jessetrinity/TypeScript that referenced this pull request May 19, 2021
jessetrinity pushed a commit that referenced this pull request May 19, 2021
* Revert "Only issue matching token errors on non-dupe locations (#43460)"

This reverts commit 76a2ae3.

* Revert "Adding Diagnostic message for missing ']' and ')' in Array literal and conditional statements (#40884)"

This reverts commit 555ef73.

* re-add clobbered merge lines
jessetrinity pushed a commit to jessetrinity/TypeScript that referenced this pull request May 20, 2021
* Revert "Only issue matching token errors on non-dupe locations (microsoft#43460)"

This reverts commit 76a2ae3.

* Revert "Adding Diagnostic message for missing ']' and ')' in Array literal and conditional statements (microsoft#40884)"

This reverts commit 555ef73.

* re-add clobbered merge lines
DanielRosenwasser pushed a commit that referenced this pull request May 20, 2021
* Revert "Only issue matching token errors on non-dupe locations (#43460)"

This reverts commit 76a2ae3.

* Revert "Adding Diagnostic message for missing ']' and ')' in Array literal and conditional statements (#40884)"

This reverts commit 555ef73.

* re-add clobbered merge lines
jessetrinity added a commit to jessetrinity/TypeScript that referenced this pull request May 27, 2021
sandersn added a commit that referenced this pull request Mar 16, 2022
…brackets (#44158)

* Revert "Revert #43460 and #40884 (#44175)"

This reverts commit 5770434.

* fix missing opening brace match error

* refactor parseExpectedMatchingBrackets

* use getNodePos

* accept baselines

* delete mistakenly added files

* Revert getNodePos addition

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants