Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for Update the type reference cache with correct project options #44008

Merged
merged 2 commits into from May 10, 2021

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented May 8, 2021

Test for #44004

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 8, 2021
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 9, 2021

It'd be good to cherry-pick this to release-4.3 just to ensure any other patches don't cause regressions.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 10, 2021

@typescript-bot cherry-pick this to release-4.3

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 10, 2021

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.3 on this PR at 5c1ae7a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 10, 2021

Hey @DanielRosenwasser, I've opened #44029 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request May 10, 2021
Component commits:
8da9ed0 Test without change

5c1ae7a Update showing fix in microsoft#44004 works
@sheetalkamat sheetalkamat merged commit 182b6c9 into master May 10, 2021
10 checks passed
@sheetalkamat sheetalkamat deleted the missingUpdateTest branch May 10, 2021
sheetalkamat added a commit that referenced this pull request May 10, 2021
Component commits:
8da9ed0 Test without change

5c1ae7a Update showing fix in #44004 works

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants