Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #43460 and #40884 #44175

Merged

Conversation

jessetrinity
Copy link
Contributor

@jessetrinity jessetrinity commented May 19, 2021

Reverting #43460 and #40884 to cherry pick to 4.3 until we verify that we have a good fix in #44158.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 19, 2021
@jessetrinity jessetrinity force-pushed the revertBraceMatchingDiagnostics branch from ce216c3 to f537aef Compare May 19, 2021
@jessetrinity jessetrinity merged commit 5770434 into microsoft:master May 19, 2021
9 checks passed
@jessetrinity
Copy link
Contributor Author

jessetrinity commented May 19, 2021

@typescript-bot cherry-pick this to release-4.3

1 similar comment
@jessetrinity
Copy link
Contributor Author

jessetrinity commented May 20, 2021

@typescript-bot cherry-pick this to release-4.3

@jessetrinity jessetrinity deleted the revertBraceMatchingDiagnostics branch May 20, 2021
jessetrinity pushed a commit to jessetrinity/TypeScript that referenced this pull request May 20, 2021
* Revert "Only issue matching token errors on non-dupe locations (microsoft#43460)"

This reverts commit 76a2ae3.

* Revert "Adding Diagnostic message for missing ']' and ')' in Array literal and conditional statements (microsoft#40884)"

This reverts commit 555ef73.

* re-add clobbered merge lines
DanielRosenwasser pushed a commit that referenced this pull request May 20, 2021
* Revert "Only issue matching token errors on non-dupe locations (#43460)"

This reverts commit 76a2ae3.

* Revert "Adding Diagnostic message for missing ']' and ')' in Array literal and conditional statements (#40884)"

This reverts commit 555ef73.

* re-add clobbered merge lines
jessetrinity added a commit to jessetrinity/TypeScript that referenced this pull request May 27, 2021
sandersn added a commit that referenced this pull request Mar 16, 2022
…brackets (#44158)

* Revert "Revert #43460 and #40884 (#44175)"

This reverts commit 5770434.

* fix missing opening brace match error

* refactor parseExpectedMatchingBrackets

* use getNodePos

* accept baselines

* delete mistakenly added files

* Revert getNodePos addition

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants