Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanup around inlay hints types to get more-precise checking. #45391

Merged
merged 2 commits into from Aug 23, 2021

Conversation

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Aug 10, 2021

Right now, inlay hints incorrectly report that their kind might be optional. We also don't validate that the response has the shape that we're promising, so this PR ensures that we get at least some checking there.

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Aug 10, 2021

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Loading

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Aug 10, 2021

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

Loading

@sandersn sandersn added this to Not started in PR Backlog Aug 19, 2021
@sandersn sandersn moved this from Not started to Waiting on reviewers in PR Backlog Aug 19, 2021
@sandersn
Copy link
Member

@sandersn sandersn commented Aug 19, 2021

@DanielRosenwasser does this need to go into 4.4?

Loading

@DanielRosenwasser DanielRosenwasser force-pushed the inlayHintsTypeCleanup branch from 6101d34 to a2cefc5 Aug 21, 2021
@DanielRosenwasser
Copy link
Member Author

@DanielRosenwasser DanielRosenwasser commented Aug 21, 2021

@typescript-bot cherry-pick this to release-4.4

Loading

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Aug 21, 2021

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.4 on this PR at a2cefc5. You can monitor the build here.

Loading

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Aug 21, 2021

Hey @DanielRosenwasser, I've opened #45529 for you.

Loading

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue Aug 21, 2021
Component commits:
a2cefc5 Some cleanup around inlay hints types to get more-precise checking.
@DanielRosenwasser DanielRosenwasser merged commit af54990 into main Aug 23, 2021
4 checks passed
Loading
PR Backlog automation moved this from Waiting on reviewers to Done Aug 23, 2021
@DanielRosenwasser DanielRosenwasser deleted the inlayHintsTypeCleanup branch Aug 23, 2021
DanielRosenwasser added a commit that referenced this issue Aug 23, 2021
…45391)

* Some cleanup around inlay hints types to get more-precise checking.

* Update Baselines and/or Applied Lint Fixes

Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com>
BobobUnicorn added a commit to BobobUnicorn/TypeScript that referenced this issue Oct 24, 2021
…icrosoft#45391)

* Some cleanup around inlay hints types to get more-precise checking.

* Update Baselines and/or Applied Lint Fixes

Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PR Backlog
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants