Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore HTMLDocument constructable value in DOM #45554

Merged
merged 1 commit into from Aug 23, 2021

Conversation

@sandersn
Copy link
Member

@sandersn sandersn commented Aug 23, 2021

Don't touch anything else in the DOM. Less consistent with @types/web than #45553, but safer to ship late in 4.4's release.

Don't touch anything else in the DOM.
@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Aug 23, 2021

I’m assuming the https://github.com/microsoft/TypeScript/pull/45554/files#diff-649a115a1a1a9a6c5eeefa536f5e12d3ef96bfc1c9ea437c42aa28f685ad6960 diff made sense when you viewed it locally; it references DOM types in it so I guess line numbers just changed on super long lines?

Loading

@sandersn
Copy link
Member Author

@sandersn sandersn commented Aug 23, 2021

Yep, it's just a dump of most of the DOM types, and Window lost its HTMLDocument member, replaced by the global declare var HTMLDocument

Loading

@sandersn sandersn merged commit b8ace9d into main Aug 23, 2021
10 checks passed
Loading
@sandersn sandersn deleted the restore-HTMLDocument-var-to-dom branch Aug 23, 2021
@sandersn
Copy link
Member Author

@sandersn sandersn commented Aug 23, 2021

@typescript-bot cherry-pick this to release-4.4

Loading

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Aug 23, 2021

Heya @sandersn, I've started to run the task to cherry-pick this into release-4.4 on this PR at c9846f8. You can monitor the build here.

Loading

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Aug 23, 2021

Hey @sandersn, I've opened #45555 for you.

Loading

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue Aug 23, 2021
Component commits:
c9846f8 Restore HTMLDocument constructable value in DOM
Don't touch anything else in the DOM.
sandersn added a commit that referenced this issue Aug 23, 2021
Component commits:
c9846f8 Restore HTMLDocument constructable value in DOM
Don't touch anything else in the DOM.

Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com>
BobobUnicorn added a commit to BobobUnicorn/TypeScript that referenced this issue Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants