Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close package json watches in watch mode on close #45642

Merged

Conversation

@weswigham
Copy link
Member

@weswigham weswigham commented Aug 30, 2021

Fixes #45633

Copy link
Member

@andrewbranch andrewbranch left a comment

Thanks for the quick fix!

Loading

@weswigham weswigham merged commit f598076 into microsoft:main Aug 30, 2021
10 checks passed
Loading
@weswigham
Copy link
Member Author

@weswigham weswigham commented Aug 30, 2021

@andrewbranch want this picked into the 4.4 branch?

Loading

@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Aug 30, 2021

Yes please

Loading

@weswigham
Copy link
Member Author

@weswigham weswigham commented Aug 30, 2021

@typescript-bot cherrypick this into release-4.4

Loading

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Aug 30, 2021

Heya @weswigham, I've started to run the task to cherry-pick this into release-4.4 on this PR at 58e56ed. You can monitor the build here.

Loading

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Aug 30, 2021

Hey @weswigham, I've opened #45644 for you.

Loading

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue Aug 30, 2021
Component commits:
58e56ed Close package json watches in watch mode on close
andrewbranch pushed a commit that referenced this issue Aug 30, 2021
Component commits:
58e56ed Close package json watches in watch mode on close

Co-authored-by: Wesley Wigham <t-weswig@microsoft.com>
@sunshineplan
Copy link

@sunshineplan sunshineplan commented Sep 3, 2021

@weswigham Any plan for a new release?

Loading

nicoleoliveira added a commit to animaliads/animalia-web-components that referenced this issue Sep 3, 2021
Tem uma issue no typescript porque está travando o build.
microsoft/TypeScript#45642
rollup/rollup#4213
@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Sep 3, 2021

There will be a patch probably within the next week or two.

Loading

anomiex added a commit to Automattic/jetpack that referenced this issue Sep 7, 2021
enisdenjo added a commit to enisdenjo/graphql-ws that referenced this issue Sep 8, 2021
enisdenjo added a commit to enisdenjo/graphql-ws that referenced this issue Sep 8, 2021
enisdenjo added a commit to enisdenjo/graphql-sse that referenced this issue Sep 8, 2021
nicoleoliveira added a commit to animaliads/animalia-web-components that referenced this issue Sep 10, 2021
* Novo componente 

* feat: correção da versão do typescript

Tem uma issue no typescript porque está travando o build.
microsoft/TypeScript#45642
rollup/rollup#4213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants