Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set package data map under watch mode #46211

Merged

Conversation

@weswigham
Copy link
Member

@weswigham weswigham commented Oct 4, 2021

Since they're only used to make watchers in watch mode, the map can be left empty if the watch flag is unset. While we should still take #46209 or #46208 (pending one or both of them fixing the perf issues) to improve watch mode perf, this change should limit the impact of the remaining realpath calls to only the mode they're actually needed for.

@weswigham weswigham force-pushed the only-set-package-realpaths-in-watch-mode branch from 1f624f3 to f17c7fd Oct 5, 2021
@weswigham weswigham merged commit 47cd4d3 into microsoft:main Oct 5, 2021
10 checks passed
Loading
@amcasey
Copy link
Member

@amcasey amcasey commented Oct 5, 2021

Seems right. 👍

Loading

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Oct 5, 2021

@typescript-bot cherry-pick this to release-4.4

Loading

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Oct 5, 2021

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.4 on this PR at f17c7fd. You can monitor the build here.

Loading

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Oct 5, 2021

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.4 manually.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants