Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃 Pick PR #46594 (fix(46589): Extra ? added to method...) into release-4.5 #46667

Conversation

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Nov 3, 2021

This cherry-pick was triggered by a request on #46594
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.

cc @andrewbranch

Component commits:
cd33fc8 fix(46589): omit ? in method signature completion for optional methods
Method = 1 << 0,
Property = 1 << 1,
All = Method | Property
Copy link
Member

@DanielRosenwasser DanielRosenwasser Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursed.

@DanielRosenwasser DanielRosenwasser merged commit e4a2494 into microsoft:release-4.5 Nov 3, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants