Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(47820): Assertion crash when requesting refactorings in JSDoc comment with {@link } on next line #47830

Merged
merged 1 commit into from Feb 17, 2022

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Feb 10, 2022

Fixes #47820

@typescript-bot typescript-bot added the For Milestone Bug label Feb 10, 2022
Copy link
Member

@gabritto gabritto left a comment

thanks

src/services/refactors/extractSymbol.ts Show resolved Hide resolved
@DanielRosenwasser DanielRosenwasser requested a review from sandersn Feb 10, 2022
@sandersn sandersn merged commit 03a4df7 into microsoft:main Feb 17, 2022
10 checks passed
@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Feb 17, 2022

@typescript-bot cherry-pick this to release-4.6

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Feb 17, 2022

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.6 on this PR at 8f0e935. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Feb 17, 2022

Hey @DanielRosenwasser, I've opened #47928 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue Feb 17, 2022
Component commits:
8f0e935 fix(47820): forbid extraction jsdoc
DanielRosenwasser pushed a commit that referenced this issue Feb 18, 2022
Component commits:
8f0e935 fix(47820): forbid extraction jsdoc

Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants