Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only suggest @param codefixes in TS #47959

Merged
merged 4 commits into from Feb 18, 2022
Merged

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Feb 18, 2022

Previously, there were 2 JS errors that were issued as suggestions in TS files. But there was no codefix for these errors, and the errors were incorrect in TS.

This PR only issues the JS-specific errors on JS files.

Fixes bug discovered by @DanielRosenwasser and @dragomirtitian

Fixes #47949

sandersn added 2 commits Feb 18, 2022
Previously, there were 2 JS errors that were issued as suggestions in TS
files. But there was no codefix for these errors, and the errors were
incorrect in TS.

This PR only issues the JS-specific errors on JS files.
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug labels Feb 18, 2022
@sandersn sandersn changed the title Only suggest param codefixes in ts Only suggest @param codefixes in TS Feb 18, 2022
@sandersn sandersn requested a review from DanielRosenwasser Feb 18, 2022
@sandersn sandersn added this to Not started in PR Backlog via automation Feb 18, 2022
@sandersn sandersn moved this from Not started to Waiting on reviewers in PR Backlog Feb 18, 2022
@sandersn
Copy link
Member Author

@sandersn sandersn commented Feb 18, 2022

@a-tarasyuk I can't add you as a reviewer, but you're probably interested in this.

@a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Feb 18, 2022

Fixes #47949. I thought all suggestions should work for TS/JS, so I’ve created PR that ignores errors on resolving type references. :(. Anyway, I’ve closed it in favor of your PR. Thanks.

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Feb 18, 2022

@typescript-bot cherry-pick this to release-4.6

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Feb 18, 2022

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.6 on this PR at 72499ac. You can monitor the build here.

PR Backlog automation moved this from Waiting on reviewers to Needs merge Feb 18, 2022
@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Feb 18, 2022

Hey @DanielRosenwasser, I've opened #47962 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue Feb 18, 2022
Component commits:
465042e Only issue @param suggestions with codefixes in TS
Previously, there were 2 JS errors that were issued as suggestions in TS
files. But there was no codefix for these errors, and the errors were
incorrect in TS.

This PR only issues the JS-specific errors on JS files.

4056b38 Minimise test

4fb10f1 Merge branch 'main' into only-suggest-param-codefixes-in-ts

72499ac Merge branch 'main' into only-suggest-param-codefixes-in-ts
@sandersn sandersn merged commit 5150682 into main Feb 18, 2022
11 checks passed
PR Backlog automation moved this from Needs merge to Done Feb 18, 2022
@sandersn sandersn deleted the only-suggest-param-codefixes-in-ts branch Feb 18, 2022
DanielRosenwasser pushed a commit that referenced this issue Feb 19, 2022
Component commits:
465042e Only issue @param suggestions with codefixes in TS
Previously, there were 2 JS errors that were issued as suggestions in TS
files. But there was no codefix for these errors, and the errors were
incorrect in TS.

This PR only issues the JS-specific errors on JS files.

4056b38 Minimise test

4fb10f1 Merge branch 'main' into only-suggest-param-codefixes-in-ts

72499ac Merge branch 'main' into only-suggest-param-codefixes-in-ts

Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug
Projects
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

4 participants