Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hasOwn from Object instance to Object constructor #48207

Merged
merged 1 commit into from Mar 10, 2022

Conversation

RyanCavanaugh
Copy link
Member

@RyanCavanaugh RyanCavanaugh commented Mar 10, 2022

Fixes #48206

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug labels Mar 10, 2022
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Mar 10, 2022

🤦‍♂️

In checker.ts we have some logic for reporting whether or not the lib has to be adjusted for newer methods. Is that correct as well?

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Mar 10, 2022

Nah should be fine.

image

Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Should we cherry-pick to release-4.6 and release a patch?

@RyanCavanaugh
Copy link
Member Author

RyanCavanaugh commented Mar 10, 2022

I think so, this will not be the first report of it

@RyanCavanaugh
Copy link
Member Author

RyanCavanaugh commented Mar 10, 2022

@typescript-bot cherry-pick this to release-4.6

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 10, 2022

Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into release-4.6 on this PR at d1b063e. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 10, 2022

Hey @RyanCavanaugh, I've opened #48213 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue Mar 10, 2022
Component commits:
d1b063e Move `hasOwn` from Object instance to Object constructor
Fixes microsoft#48206
@RyanCavanaugh RyanCavanaugh merged commit a4f5555 into microsoft:main Mar 10, 2022
10 checks passed
@RyanCavanaugh RyanCavanaugh deleted the fixHasOwn branch Mar 10, 2022
DanielRosenwasser pushed a commit that referenced this issue Mar 11, 2022
Component commits:
d1b063e Move `hasOwn` from Object instance to Object constructor
Fixes #48206

Co-authored-by: Ryan Cavanaugh <ryanca@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants