Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module specifier generation crash from typesVersions

Merged
merged 1 commit into from May 9, 2022

Conversation

andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented May 9, 2022

Fixes microsoft/tsserverfuzzer#409 introduced by #48995

Also discovered #49034, but will fix that separately as it’s been the behavior at least since 4.5 (probably for years)

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug labels May 9, 2022
@andrewbranch
Copy link
Member Author

andrewbranch commented May 9, 2022

@typescript-bot cherry-pick this to release-4.7

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 9, 2022

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.7 on this PR at e8df495. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 9, 2022

Hey @andrewbranch, I've opened #49036 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue May 9, 2022
Component commits:
e8df495 Fix module specifier generation crash from typesVersions
@andrewbranch andrewbranch merged commit f3f0a3f into microsoft:main May 9, 2022
10 checks passed
@andrewbranch andrewbranch deleted the bug/fuzzer-409 branch May 9, 2022
andrewbranch added a commit that referenced this issue May 9, 2022
Component commits:
e8df495 Fix module specifier generation crash from typesVersions

Co-authored-by: Andrew Branch <andrew@wheream.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants