Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the implicit glob key so that recursive keys are not differing just directory separator for wildcard directory #49246

Merged
merged 3 commits into from May 25, 2022

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented May 25, 2022

Fixes #49078

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug labels May 25, 2022
@sheetalkamat sheetalkamat requested review from andrewbranch and weswigham and removed request for andrewbranch May 25, 2022
@sheetalkamat sheetalkamat merged commit 0ad5f82 into main May 25, 2022
11 checks passed
@sheetalkamat sheetalkamat deleted the wildCard branch May 25, 2022
@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented May 25, 2022

@RyanCavanaugh @andrewbranch do we feel alright picking this into 4.7?

I'll kick off a cherry-pick in the meantime.

@typescript-bot cherry-pick this to release-4.7

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented May 25, 2022

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.7 on this PR at f93951f. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented May 25, 2022

Hey @DanielRosenwasser, I've opened #49250 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue May 25, 2022
Component commits:
b846905 Add failing test

66d51e5 Fix the implicit glob key so that recursive keys are not differing just by directory seperator Fixes microsoft#49078

f93951f Reset the reload level once program is loaded
DanielRosenwasser pushed a commit that referenced this issue Jun 1, 2022
Component commits:
b846905 Add failing test

66d51e5 Fix the implicit glob key so that recursive keys are not differing just by directory seperator Fixes #49078

f93951f Reset the reload level once program is loaded

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants