Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(49306): Missing Compiler API predicate functions: isImportTypeAssertionContainer #49313

Merged
merged 1 commit into from Jun 2, 2022

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented May 30, 2022

Fixes #49306

@typescript-bot typescript-bot added the For Uncommitted Bug label May 30, 2022
src/compiler/factory/nodeTests.ts Outdated Show resolved Hide resolved
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jun 1, 2022

Should we be adding this if technically resolution-mode on an import(...) type should be an error?

@DanielRosenwasser DanielRosenwasser requested a review from weswigham Jun 1, 2022
@typescript-bot typescript-bot added For Milestone Bug and removed For Uncommitted Bug labels Jun 1, 2022
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jun 2, 2022

Should we be adding this if technically resolution-mode on an import(...) type should be an error?

I think we can if #49354 is addressed.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jun 2, 2022

@typescript-bot cherry-pick this to release-4.7

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 2, 2022

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.7 on this PR at 00b7574. You can monitor the build here.

@DanielRosenwasser DanielRosenwasser merged commit c6447f9 into microsoft:main Jun 2, 2022
10 checks passed
@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 2, 2022

Hey @DanielRosenwasser, I've opened #49359 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue Jun 2, 2022
Component commits:
00b7574 fix(49306): add isImportTypeAssertionContainer helper
DanielRosenwasser pushed a commit that referenced this issue Jun 2, 2022
Component commits:
00b7574 fix(49306): add isImportTypeAssertionContainer helper

Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants