-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make getSupportedCodeFixes plugin test such that we dont need to update its baseline for every new error #53070
Conversation
…te its baseline for every new error Take 2
/** @internal */ | ||
export function getSupportedErrorCodes(): readonly string[] { | ||
return arrayFrom(errorCodeToFixes.keys()); | ||
return errorCodeToFixesArray ??= arrayFrom(errorCodeToFixes.keys()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codefixes are registered at runtime, so if this call happens too early it may get locked in forever with a reduced list.
Can we add something like errorCodeToFixesArray = undefined
to registerCodeFix
above just to make sure this function is always accurate? It's unlikely, but, seems like it'd be a bit annoying to have to debug if we did accidentally cause this to happen. 😅
(I want to get rid of this registration mechanism at some point, as it's side-effect based and could be redone post-modules, but, that's another change.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now how this is setup is that this is immutable list and is correct when called. I will go ahead and add assert in register code fix though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd be surprised; I know of a few projects which add more on:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow .. thats just misusing it.. their plugin instead needs to implement getSupportedCodeFixes
on LS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An assert would stop those cases from functioning, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An assert would stop those cases from functioning, right?
Yeah for now i have just gone ahead with resetting the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear I'm not against breaking this particular mechanism of adding code fixes. I'm curious why they did this; hopefully it was just because they didn't know about getSupportedCodeFixes
, but maybe there's a restriction there I'm not thinking of. tsec is one that I think is actively maintained. The roblox one is... confusing because it doesn't add anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The restriction is that IDEs don't use the feature so the function is never called and the proxy is useless. I created an issue: microsoft/vscode#219273
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't making more people depend on this an even worse direction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which direction?
I don't have much opinion on the design, but I think the language server should have an official API to extend code actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to have these baselines fixed!
Take 2
#52596 still left one request that was not redirected so printing all the error codes.