From e7228fb843678835e36ff181855d615a6970f446 Mon Sep 17 00:00:00 2001 From: Lars Kappert Date: Tue, 9 Dec 2025 05:09:22 +0100 Subject: [PATCH 1/3] Move knip args to config file --- Herebyfile.mjs | 2 +- knip.jsonc | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Herebyfile.mjs b/Herebyfile.mjs index 0f4f8344008b2..aca96dc28c911 100644 --- a/Herebyfile.mjs +++ b/Herebyfile.mjs @@ -601,7 +601,7 @@ export const knip = task({ name: "knip", description: "Runs knip.", dependencies: [generateDiagnostics], - run: () => exec(process.execPath, ["node_modules/knip/bin/knip.js", "--tags=+internal,-knipignore", "--exclude=duplicates,enumMembers", ...(cmdLineOptions.fix ? ["--fix"] : [])]), + run: () => exec(process.execPath, ["node_modules/knip/bin/knip.js", ...(cmdLineOptions.fix ? ["--fix"] : [])]), }); const { main: typingsInstaller, watch: watchTypingsInstaller } = entrypointBuildTask({ diff --git a/knip.jsonc b/knip.jsonc index 5b1fa410e15da..795d90180d0c2 100644 --- a/knip.jsonc +++ b/knip.jsonc @@ -1,5 +1,7 @@ { "$schema": "https://unpkg.com/knip@5/schema.json", + "exclude": ["duplicates", "enumMembers"], + "tags": ["+internal", "-knipignore"], "includeEntryExports": true, "entry": [ "Herebyfile.mjs", From fe220d917aa509e08f3d97b16bd88df94ad148b7 Mon Sep 17 00:00:00 2001 From: Lars Kappert Date: Tue, 9 Dec 2025 05:09:42 +0100 Subject: [PATCH 2/3] Remove obsolete knipignore tag --- src/compiler/utilities.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts index cdf898ca8c3fc..4939145c433c7 100644 --- a/src/compiler/utilities.ts +++ b/src/compiler/utilities.ts @@ -4792,7 +4792,7 @@ export function getTypeParameterFromJsDoc(node: TypeParameterDeclaration & { par return typeParameters && find(typeParameters, p => p.name.escapedText === name); } -/** @internal @knipignore */ +/** @internal */ export function hasTypeArguments(node: Node): node is HasTypeArguments { return !!(node as HasTypeArguments).typeArguments; } From 2b3585a66f2e865ebae35d7e6a919e7701eb948b Mon Sep 17 00:00:00 2001 From: Lars Kappert Date: Tue, 9 Dec 2025 05:10:31 +0100 Subject: [PATCH 3/3] Remove obsolete entry --- knip.jsonc | 1 - 1 file changed, 1 deletion(-) diff --git a/knip.jsonc b/knip.jsonc index 795d90180d0c2..5badeb83e5c01 100644 --- a/knip.jsonc +++ b/knip.jsonc @@ -16,7 +16,6 @@ "src/testRunner/_namespaces/Harness.ts", // The rest of the entry files, mostly to track used dependencies: - ".eslint-plugin-local.cjs", ".gulp.js", "scripts/eslint/{rules,tests}/*.cjs", "scripts/*.{cjs,mjs}"