Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not build if System Locale is not English. #8

Closed
0xbadfca11 opened this issue Feb 3, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@0xbadfca11
Copy link

commented Feb 3, 2017

Build failure if Control Panel -> Clock, Language, and Region -> Region and Language -> Administrative -> Current language for non-Unicode programs: is not English. Build succeeded when I switched to English (United States).
Build log: https://gist.githubusercontent.com/0xbadfca11/bf4ff1307101a6b187cd31570c2fbd4a/raw/feb4f955576bf40a0d3d14bd399cc9a79c3bdbdc/gistfile1.txt

@fcharlie

This comment has been minimized.

Copy link

commented Feb 4, 2017

save gvlib.h encoding to UTF16LE

@sanoursa

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2017

Thanks for the report. We will take a look, but this is a fairly low priority issue since all of our build environments are in English. I'd be happy to take a PR from you as long as it doesn't affect English environment builds.

@boltomli

This comment has been minimized.

Copy link
Member

commented Feb 4, 2017

I guess there won't be PR until the codes in issue #5 are released because the header file looks to be from the package.

@sanoursa

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2018

VFS for Git no longer builds the ProjFS native code, so this should no longer be an issue.

@sanoursa sanoursa closed this Nov 15, 2018

jrbriggs pushed a commit that referenced this issue Mar 28, 2019

Merge pull request #8 from github/vfs-api-id-attrs
Use projection attributes for content and provider IDs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.