Upgrader: do not include Micrsoft.Diagnostic.Tracing.EventSource #1137
Conversation
| @@ -36,7 +36,6 @@ public abstract class ProductUpgrader : IDisposable | |||
| UpgraderToolConfigFile, | |||
| "GVFS.Common.dll", | |||
| "GVFS.Platform.Windows.dll", | |||
| "Microsoft.Diagnostics.Tracing.EventSource.dll", | |||
There was a problem hiding this comment.
Should we also remove any references to Microsoft.Diagnostics.Tracing left in projects\config files?
There was a problem hiding this comment.
Yes - we should. I will go and remove the other ones I find.
Does the upgrader only need to worry about files that were included with its own installation? I couldn't tell from your comment if there is an issue with older installations having this file around. |
The upgrader needs to copy over its dependencies. In this case, the file is no longer a dependency (so we do not need to copy it over), but it is still in the list of files that the upgrade verb tries to copy over. The reason why we didn't notice this before (and lessens the impact), is that users who already have this file in the installation directory (via an older installation) will still be able to upgrade, as this file is apparently not removed when installing a new version over an old version... I will update the commit message to include the commit where this file was removed from the installer (cbe5787) |
jamill
force-pushed
the
upgrader_copy_list_fix
branch
from
9dc8dac
to
71030c7
Compare
|
Looks good, thanks @jamill. Please port to release branch. |
The upgrade verb attempts to copy Microsoft.Diagnostic.Tracing.EventSource when copying the ProductUpgrader to the temporary directory to run. If this file is not present, then the upgrade verb will fail. This following commit removes this file: cbe5787 ("Remove in-proc ETW trace event listener", 2019-02-18) Clean installs of VFS4G that include this commit will no longer have this file in the installation directory, and will not be able to upgrade. This dll is no longer needed or installed during installation, so we remove it from the list of files copied over for upgrade. This is a quick fix - we will also see how to make this less fragile. One option might be to install "upgrader app" into its own directory under the VFS For Git installation directory, and then just copy the directory to the temp location, instead of providing a list of files that need to be kept in sync.
jamill
force-pushed
the
upgrader_copy_list_fix
branch
from
71030c7
to
f107731
Compare
Product code no longer has a dependency on Microsoft.Diagnostics.Tracing.EventSource, so remove references to NuGet packages.
|
I added a new commit to remove references to the I will only bring the first commit over when I port the changes to release branches. |
The upgrade verb attempts to copy
Microsoft.Diagnostic.Tracing.EventSource when copying the
ProductUpgrader to the temporary directory to run. However, this dll is
no longer needed or installed during installation.
Older installations will have copied this file into the install
directory will still have a copy for the upgrade verb to copy over.
However, clean installs, or if you uninstall VFS4G and re-install, will
not have this dll and upgrade will fail.
This is a quick fix - we will also see how to make this less fragile.
One option might be to install "upgrader app" into its own directory
under the VFS For Git installation directory, and then just copy the
directory to the temp location, instead of providing a list of files
that need to be kept in sync.