Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dockerfile #211

Merged
merged 4 commits into from Jan 29, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jan 29, 2019

This pull request makes a few minor tweaks to the Dockerfile:

  • Avoid full rebuild when only dependencies change
  • Merge layers to reduce image size
  • Parameterize kafka version

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)? Not applicable: infrastructure change

  • Have you added tests to cover your changes? Not applicable: infrastructure change

  • Have you linted your code prior to submission? Not applicable: infrastructure change

  • Have you updated the documentation and README? Not applicable: no API surface change

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not applicable: infrastructure change

  • Have secrets been stripped before committing? Not applicable: infrastructure change

c-w and others added some commits Jan 29, 2019

@sayar

sayar approved these changes Jan 29, 2019

Copy link
Collaborator

left a comment

Good catch on avoiding full rebuild if deps change.

@sayar sayar merged commit 5a21ead into master Jan 29, 2019

2 checks passed

agogosml-ci Build #20190129.3 succeeded
Details
license/cla All CLA requirements met.
Details

@sayar sayar deleted the improve-dockerfile branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.