Skip to content
This repository has been archived by the owner. It is now read-only.

Add tool to send events #212

Merged
merged 4 commits into from Jan 30, 2019
Merged

Add tool to send events #212

merged 4 commits into from Jan 30, 2019

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jan 29, 2019

This pull request adds a tool to feed the agogosml input sources (Kafka and EventHub). This enables manual kick-start of the pipeline, redriving training data, etc.

The tool can be used like so:

python3 -m agogosml.tools.sender

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not applicable: no PII included

  • Have secrets been stripped before committing? Not applicable: no secrets included

sayar
sayar approved these changes Jan 29, 2019
Copy link
Collaborator

@sayar sayar left a comment

Looks good, just a couple of nitpicks.

agogosml/agogosml/tools/sender.py Show resolved Hide resolved
agogosml/agogosml/tools/sender.py Show resolved Hide resolved
agogosml/setup.cfg Show resolved Hide resolved
@c-w c-w mentioned this pull request Jan 30, 2019
13 tasks
@sayar sayar merged commit 9319d76 into master Jan 30, 2019
2 checks passed
@sayar sayar deleted the sender-tool branch Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants