Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tool to send events #212

Merged
merged 4 commits into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jan 29, 2019

This pull request adds a tool to feed the agogosml input sources (Kafka and EventHub). This enables manual kick-start of the pipeline, redriving training data, etc.

The tool can be used like so:

python3 -m agogosml.tools.sender

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not applicable: no PII included

  • Have secrets been stripped before committing? Not applicable: no secrets included

@sayar

sayar approved these changes Jan 29, 2019

Copy link
Collaborator

left a comment

Looks good, just a couple of nitpicks.

Show resolved Hide resolved agogosml/agogosml/tools/sender.py
Show resolved Hide resolved agogosml/agogosml/tools/sender.py
Show resolved Hide resolved agogosml/setup.cfg

@c-w c-w referenced this pull request Jan 30, 2019

Merged

Add isort import style linter #217

13 of 13 tasks complete

@sayar sayar merged commit 9319d76 into master Jan 30, 2019

2 checks passed

agogosml-ci Build #20190130.8 succeeded
Details
license/cla All CLA requirements met.
Details

@sayar sayar deleted the sender-tool branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.