This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Replace os.path with pathlib - #214
Merged
Merged
Conversation
Clemens Wolff (c-w)
force-pushed
the
pathlib
branch
from
January 29, 2019 20:49
b3880a0 to
f74b4ba
Compare
This makes the code a lot more natural to read. See [PEP 428](https://www.python.org/dev/peps/pep-0428/#why-an-object-oriented-api) for more information on why pathlib is a desirable improvement over the more low-level os.path.
Clemens Wolff (c-w)
force-pushed
the
pathlib
branch
from
January 29, 2019 20:59
f74b4ba to
6e3c7bc
Compare
Contributor
Author
|
Rami Sayar (@sayar) There seems to be something wrong with the CI definition for the cli and app. The build here fails, but running the Dockerfile locally succeeds with |
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request refactors all references to
os.pathto use the new pathlib module.This makes the code a lot more natural to read. See PEP 428 for more information on why
pathlibis a desirable improvement over the more low-levelos.path.All Submissions:
Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Does your PR follow our Code of Conduct?
Have you added an explanation of what your changes do and why you'd like us to include them?
Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability. Not applicable: pure refactor
Is this code designed to be testable? Not applicable: pure refactor
Is the code documented well? Not applicable: pure refactor
Does your submission pass existing tests (or update existing tests with documentation regarding the change)? Docker build passes
Have you added tests to cover your changes? Not applicable: pure refactor
Have you linted your code prior to submission? Docker build passes
Have you updated the documentation and README? Not applicable: pure refactor
Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not applicable: none included
Have secrets been stripped before committing? Not applicable: none included