Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace os.path with pathlib #214

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jan 29, 2019

This pull request refactors all references to os.path to use the new pathlib module.

This makes the code a lot more natural to read. See PEP 428 for more information on why pathlib is a desirable improvement over the more low-level os.path.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability. Not applicable: pure refactor

  • Is this code designed to be testable? Not applicable: pure refactor

  • Is the code documented well? Not applicable: pure refactor

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)? Docker build passes

  • Have you added tests to cover your changes? Not applicable: pure refactor

  • Have you linted your code prior to submission? Docker build passes

  • Have you updated the documentation and README? Not applicable: pure refactor

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not applicable: none included

  • Have secrets been stripped before committing? Not applicable: none included

@c-w c-w force-pushed the pathlib branch from b3880a0 to f74b4ba Jan 29, 2019

Replace os.path with pathlib
This makes the code a lot more natural to read. See
[PEP 428](https://www.python.org/dev/peps/pep-0428/#why-an-object-oriented-api)
for more information on why pathlib is a desirable improvement over the
more low-level os.path.

@c-w c-w force-pushed the pathlib branch from f74b4ba to 6e3c7bc Jan 29, 2019

@c-w

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2019

@sayar There seems to be something wrong with the CI definition for the cli and app.

The build here fails, but running the Dockerfile locally succeeds with docker build -t agogosml/cli -f agogosml_cli/Dockerfile agogosml_cli (see screenshot below). So the CI fail here should not be considered a blocker.

image

@c-w c-w referenced this pull request Jan 29, 2019

Merged

Improve CLI Dockerfile #215

13 of 13 tasks complete
@sayar

sayar approved these changes Jan 29, 2019

Copy link
Collaborator

left a comment

LOVE IT!

@sayar sayar merged commit 0a910cd into master Jan 29, 2019

4 checks passed

agogosml-app-ci Build #20190129.5 succeeded
Details
agogosml-ci Build #20190129.9 succeeded
Details
agogosml-cli-ci Build #20190129.13 succeeded
Details
license/cla All CLA requirements met.
Details

@sayar sayar deleted the pathlib branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.