Skip to content
This repository has been archived by the owner. It is now read-only.

Add AppInsights telemetry #216

Merged
merged 15 commits into from Jan 30, 2019
Merged

Add AppInsights telemetry #216

merged 15 commits into from Jan 30, 2019

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jan 30, 2019

This change adds Azure Application Insights telemetry to the application. For now, only logs are sent to AppInsights, but in the future custom events or metrics can also be sent (e.g. to track predictions or training runs).

The change also includes some improvements/refactoring to the logger class:

  • Factor out shared logging code
  • Avoid doing work in constructor
  • Remove custom singleton implementation

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes? Not application: refactor

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not application: refactor

  • Have secrets been stripped before committing? Not application: refactor

sayar
sayar approved these changes Jan 30, 2019
@sayar sayar merged commit 2267613 into master Jan 30, 2019
2 checks passed
@sayar sayar deleted the appinsights branch Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants