Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppInsights telemetry #216

Merged
merged 15 commits into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jan 30, 2019

This change adds Azure Application Insights telemetry to the application. For now, only logs are sent to AppInsights, but in the future custom events or metrics can also be sent (e.g. to track predictions or training runs).

The change also includes some improvements/refactoring to the logger class:

  • Factor out shared logging code
  • Avoid doing work in constructor
  • Remove custom singleton implementation

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes? Not application: refactor

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not application: refactor

  • Have secrets been stripped before committing? Not application: refactor

@c-w c-w force-pushed the appinsights branch from acaf47c to a1540ab Jan 30, 2019

@c-w c-w force-pushed the appinsights branch from ff6c6c6 to 126c9c3 Jan 30, 2019

c-w and others added some commits Jan 30, 2019

@sayar

sayar approved these changes Jan 30, 2019

@sayar sayar merged commit 2267613 into master Jan 30, 2019

2 checks passed

agogosml-ci Build #20190130.30 succeeded
Details
license/cla All CLA requirements met.
Details

@sayar sayar deleted the appinsights branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.