Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make client class lookup dynamic in factory #219

Merged
merged 4 commits into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jan 30, 2019

Currently, the InputReaderFactory has a hard-coded list of streaming clients which it can instantiate. This change ports the dynamic instantiation from the sender tool to the factory to remove the hard-coding and enable the factory to create arbitrary clients.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README? Not applicable: refactor

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not applicable: refactor

  • Have secrets been stripped before committing? Not applicable: refactor

@c-w c-w force-pushed the dynamic-factory branch from 5fdc39e to 072ca0e Jan 30, 2019

@c-w c-w force-pushed the dynamic-factory branch from 072ca0e to cca9f21 Jan 30, 2019

@sayar

sayar approved these changes Jan 30, 2019

@sayar sayar merged commit 5430386 into master Jan 30, 2019

2 checks passed

agogosml-ci Build #20190130.31 succeeded
Details
license/cla All CLA requirements met.
Details

@sayar sayar deleted the dynamic-factory branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.