Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shared factory code #222

Merged
merged 4 commits into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jan 31, 2019

This change removes the hard-coded streaming client names in the output writer factory by leveraging the dynamic instantiation code from the input writer factory.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes? Not applicable: refactor

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README? Not applicable: refactor

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not applicable: refactor

  • Have secrets been stripped before committing? Not applicable: refactor

@c-w c-w referenced this pull request Jan 31, 2019

Merged

Add broadcast streaming client #224

13 of 13 tasks complete
@sayar

sayar approved these changes Jan 31, 2019

@sayar sayar merged commit 17bb109 into master Jan 31, 2019

2 checks passed

agogosml-ci Build #20190131.5 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.