Skip to content
This repository has been archived by the owner. It is now read-only.

Accept arbitrary streaming client configuration #223

Merged
merged 2 commits into from Jan 31, 2019
Merged

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jan 31, 2019

Previously, the type definition for the streaming client interface specified a string-string dictionary. However, arbitrary json inputs are supported. This change fixes the type definition and related tooling.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).

  • Have secrets been stripped before committing?

sayar
sayar approved these changes Jan 31, 2019
@c-w c-w force-pushed the fix-type-definition branch from ae2c440 to 5581c31 Jan 31, 2019
@sayar sayar merged commit 98614ac into master Jan 31, 2019
2 checks passed
Loading
@sayar sayar deleted the fix-type-definition branch Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants