Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broadcast streaming client #224

Merged
merged 3 commits into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jan 31, 2019

Should be reviewed after #222 since this pull request depends on that branch.

This pull request adds a wrapper streaming client which enables distribution of a message to multiple streaming client implementations. This is useful to for example configure an output writer which sends outputs to both kafka and eventhub.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).

  • Have secrets been stripped before committing?

@c-w c-w force-pushed the broadcast-client branch from e41f032 to c3b7650 Jan 31, 2019

@sayar sayar merged commit f1ddc85 into refactor-shared-factory-code Jan 31, 2019

1 check passed

license/cla All CLA requirements met.
Details

@sayar sayar deleted the broadcast-client branch Jan 31, 2019

@c-w c-w referenced this pull request Jan 31, 2019

Merged

Add broadcast streaming client #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.