Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract listener client and message sender interfaces #226

merged 5 commits into from Jan 31, 2019


None yet
2 participants
Copy link

commented Jan 31, 2019

Unlike the streaming client, the listener client and message sender interfaces are concrete in the types of arguments that all of its implementations receive (e.g. port and host). However, there are potential implementations for which these arguments won't be appropriate (e.g. a docker-client based message sender). As such, this pull request refactors the constructor signatures to follow the config-dictionary pattern. This will also enable dynamic creation and configuration of the classes in the future.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).

  • Have secrets been stripped before committing?

c-w and others added some commits Jan 31, 2019


sayar approved these changes Jan 31, 2019

@c-w c-w merged commit a8a6bc5 into master Jan 31, 2019

2 checks passed

agogosml-ci Build #20190131.13 succeeded
license/cla All CLA requirements met.

@c-w c-w deleted the abstract-interfaces branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.