Skip to content
This repository has been archived by the owner. It is now read-only.

Delay string formatting when logging messages #227

Merged
merged 2 commits into from Jan 31, 2019
Merged

Delay string formatting when logging messages #227

merged 2 commits into from Jan 31, 2019

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jan 31, 2019

If we pass format strings and format arguments to the Python standard library logger, it can determine whether the logger currently is enabled and save a string interpolation if the message anyways wouldn't be logged.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README? Not applicable

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not applicable

  • Have secrets been stripped before committing? Not applicable

sayar
sayar approved these changes Jan 31, 2019
Copy link
Collaborator

@sayar sayar left a comment

👍

If we pass format strings and format arguments to the Python standard
library logger, it can determine whether the logger currently is enabled
and save a string interpolation if the message anyways wouldn't be
logged.
@c-w c-w merged commit 0ac8c27 into master Jan 31, 2019
2 checks passed
@c-w c-w deleted the fix-logging branch Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants