Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Replace pipenv with pip #229

Merged
merged 4 commits into from Feb 1, 2019
Merged

Replace pipenv with pip #229

merged 4 commits into from Feb 1, 2019

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jan 31, 2019

Remove the need for developers to list runtime dependencies both in Pipfile and in setup.py, also we discovered several issues with pipenv:

  • Very slow during CI
  • Increases Docker image size
  • Locking can cause hard to debug CI failure
  • Does not work well on Windows+WSL

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes? Not applicable: infrastructure

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README? Not applicable: infrastructure

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not applicable: infrastructure

  • Have secrets been stripped before committing? Not applicable: infrastructure

@c-w c-w force-pushed the duplicate-requirements branch 2 times, most recently from 585157e to b9a28ec Compare February 1, 2019 16:26
In docker the filesystem at the end of each RUN statement gets
serialized into the image. This means that if we do apk add in one RUN
and apk del in another one, the image size doesn't actually reduce since
all the additions were serialized into a layer after the first step.
@c-w c-w changed the title Remove the need to list duplicate requirements Replace pipenv with pip Feb 1, 2019
Copy link
Contributor

@sayar sayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline.

We discovered several issues with pipenv:

- Very slow during CI
- Increases Docker image size
- Locking can cause hard to debug CI failure
- Does not work well on Windows+WSL
@c-w c-w merged commit 1608590 into master Feb 1, 2019
@c-w c-w deleted the duplicate-requirements branch February 1, 2019 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants