Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pipenv with pip #229

Merged
merged 4 commits into from Feb 1, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jan 31, 2019

Remove the need for developers to list runtime dependencies both in Pipfile and in setup.py, also we discovered several issues with pipenv:

  • Very slow during CI
  • Increases Docker image size
  • Locking can cause hard to debug CI failure
  • Does not work well on Windows+WSL

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes? Not applicable: infrastructure

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README? Not applicable: infrastructure

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not applicable: infrastructure

  • Have secrets been stripped before committing? Not applicable: infrastructure

@c-w c-w force-pushed the duplicate-requirements branch 2 times, most recently from 585157e to b9a28ec Jan 31, 2019

c-w added some commits Jan 31, 2019

Merge layers
In docker the filesystem at the end of each RUN statement gets
serialized into the image. This means that if we do apk add in one RUN
and apk del in another one, the image size doesn't actually reduce since
all the additions were serialized into a layer after the first step.

@c-w c-w force-pushed the duplicate-requirements branch from b9a28ec to 40a2ab4 Feb 1, 2019

@c-w c-w changed the title Remove the need to list duplicate requirements Replace pipenv with pip Feb 1, 2019

@c-w c-w force-pushed the duplicate-requirements branch from 40a2ab4 to ba4e2dd Feb 1, 2019

@sayar

sayar approved these changes Feb 1, 2019

Copy link
Collaborator

left a comment

Discussed offline.

Replace pipenv with pip
We discovered several issues with pipenv:

- Very slow during CI
- Increases Docker image size
- Locking can cause hard to debug CI failure
- Does not work well on Windows+WSL

@c-w c-w force-pushed the duplicate-requirements branch from ba4e2dd to 6f27c07 Feb 1, 2019

@c-w c-w merged commit 1608590 into master Feb 1, 2019

3 checks passed

agogosml-ci Build #20190201.21 succeeded
Details
agogosml-cli-ci Build #20190201.19 succeeded
Details
license/cla All CLA requirements met.
Details

@c-w c-w deleted the duplicate-requirements branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.