Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Add bandit linter#240

Merged
sayar merged 1 commit intomasterfrom
bandit
Feb 3, 2019
Merged

Add bandit linter#240
sayar merged 1 commit intomasterfrom
bandit

Conversation

@c-w
Copy link
Copy Markdown
Contributor

@c-w c-w commented Feb 1, 2019

This change adds a security vulnerability linter: bandit.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).

  • Have secrets been stripped before committing?

@c-w c-w force-pushed the bandit branch 5 times, most recently from 07ae1f2 to be00131 Compare February 1, 2019 21:18
@sayar sayar merged commit 38b0a97 into master Feb 3, 2019
@sayar sayar deleted the bandit branch February 3, 2019 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants