Skip to content
This repository has been archived by the owner. It is now read-only.

Add local kafka docker-compose file #242

Merged
merged 1 commit into from Feb 4, 2019
Merged

Add local kafka docker-compose file #242

merged 1 commit into from Feb 4, 2019

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Feb 4, 2019

Add option to run the pipeline locally/offline by using a kafka container.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).

  • Have secrets been stripped before committing?

@c-w c-w requested review from cicorias and margaretmeehan Feb 4, 2019
Copy link
Contributor

@margaretmeehan margaretmeehan left a comment

Thanks !

@c-w c-w merged commit cd2e86c into master Feb 4, 2019
2 checks passed
@c-w c-w deleted the local-kafka branch Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants