Skip to content
This repository has been archived by the owner. It is now read-only.

Remove config duplication #253

Merged
merged 5 commits into from Feb 6, 2019
Merged

Remove config duplication #253

merged 5 commits into from Feb 6, 2019

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Feb 6, 2019

This change includes:

  • Make broadcast clients config key more explicit
  • Remove redundant configuration specification
  • Enable non-string values to be passed as config

Also @margaretmeehan take a look at 07ae916; I wonder if this odd naming was the cause of the earlier bug you saw where the pipeline only works with specific topics. It's a bit odd to me that the output writer would look at the KAFKA_TOPIC_INPUT environment variable instead of the OUTPUT one so I replaced that env deference.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).

  • Have secrets been stripped before committing?

@c-w c-w requested a review from sayar Feb 6, 2019
@c-w c-w force-pushed the config branch 2 times, most recently from c74f28e to bed7675 Feb 6, 2019
sayar
sayar approved these changes Feb 6, 2019
@sayar sayar merged commit 93d9ca4 into master Feb 6, 2019
3 checks passed
@sayar sayar deleted the config branch Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants