Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config duplication #253

Merged
merged 5 commits into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Feb 6, 2019

This change includes:

  • Make broadcast clients config key more explicit
  • Remove redundant configuration specification
  • Enable non-string values to be passed as config

Also @margaretmeehan take a look at 07ae916; I wonder if this odd naming was the cause of the earlier bug you saw where the pipeline only works with specific topics. It's a bit odd to me that the output writer would look at the KAFKA_TOPIC_INPUT environment variable instead of the OUTPUT one so I replaced that env deference.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).

  • Have secrets been stripped before committing?

@c-w c-w requested a review from sayar Feb 6, 2019

@c-w c-w force-pushed the config branch from 07ae916 to a531d62 Feb 6, 2019

@c-w c-w force-pushed the config branch 2 times, most recently from c74f28e to bed7675 Feb 6, 2019

@c-w c-w force-pushed the config branch from bed7675 to 099a018 Feb 6, 2019

@sayar

sayar approved these changes Feb 6, 2019

@sayar sayar merged commit 93d9ca4 into master Feb 6, 2019

3 checks passed

agogosml-ci Build #20190206.16 succeeded
Details
agogosml-cli-ci Build #20190206.9 succeeded
Details
license/cla All CLA requirements met.
Details

@sayar sayar deleted the config branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.