Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Add storage streaming client #254

Merged
merged 4 commits into from
Feb 6, 2019
Merged

Add storage streaming client #254

merged 4 commits into from
Feb 6, 2019

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Feb 6, 2019

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).

  • Have secrets been stripped before committing?

@c-w c-w requested a review from sayar February 6, 2019 21:13
@c-w c-w merged commit dc861de into master Feb 6, 2019
@c-w c-w deleted the storage branch February 6, 2019 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants