Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppInsights deployment scripts #270

Merged
merged 5 commits into from Feb 20, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Feb 20, 2019

This pull request adds a terraform script to set up Application Insights. It also wire-up the Application Insights environment variable in documentation, helm and docker-compose.

VSO/532

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable? Not applicable: devops

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)? Not applicable: devops

  • Have you added tests to cover your changes? Not applicable: devops

  • Have you linted your code prior to submission? Not applicable: devops

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not applicable: devops

  • Have secrets been stripped before committing?

@sayar

sayar approved these changes Feb 20, 2019

@sayar

This comment has been minimized.

Copy link
Collaborator

commented Feb 20, 2019

@c-w can you please resolve conflicts? Thank you!

@c-w c-w force-pushed the appinsights-deployment branch from c583fde to 12d9f3c Feb 20, 2019

@c-w c-w merged commit 95598ef into master Feb 20, 2019

2 checks passed

agogosml-cli-ci Build #20190220.8 succeeded
Details
license/cla All CLA requirements met.
Details

@c-w c-w deleted the appinsights-deployment branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.