Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set AppInsights endpoint URL #273

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Feb 22, 2019

This enables optionally using the AppInsights client SDK with an
on-premises telemetry storage.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes? Not applicable

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). Not applicable

  • Have secrets been stripped before committing? Not applicable

Add option to set AppInsights endpoint URL
This enables optionally using the AppInsights client SDK with an
on-premises telemetry storage.
@sayar

sayar approved these changes Feb 22, 2019

@sayar sayar merged commit c043591 into master Feb 22, 2019

6 checks passed

agogosml-ci Build #20190222.1 succeeded
Details
agogosml-ci (Agogosml-Build-CI) Agogosml-Build-CI succeeded
Details
agogosml-ci (InputReader-Build-CI) InputReader-Build-CI succeeded
Details
agogosml-ci (OutputWriter-Build-CI) OutputWriter-Build-CI succeeded
Details
agogosml-cli-ci Build #20190222.1 succeeded
Details
license/cla All CLA requirements met.
Details

@sayar sayar deleted the appinsights-endpoint branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.