Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace null telemetry client with null sender #291

merged 1 commit into from Mar 11, 2019


None yet
2 participants
Copy link

commented Mar 5, 2019

Remove some custom code in favor of code implemented in AppInsights SDK.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes? N/A: refactor

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README? N/A: refactor

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers). N/A: refactor

  • Have secrets been stripped before committing? N/A: refactor

@c-w c-w force-pushed the remove-null-telemetry-client branch from a9fee1d to b258a4e Mar 6, 2019

@c-w c-w force-pushed the remove-null-telemetry-client branch 2 times, most recently from a02454a to 88a848b Mar 7, 2019

@c-w c-w force-pushed the remove-null-telemetry-client branch from 88a848b to 2322625 Mar 7, 2019


sayar approved these changes Mar 11, 2019

@sayar sayar merged commit 9e6a4a4 into master Mar 11, 2019

6 checks passed

Agogosml CLI Build #20190307.9 succeeded
agogosml-ci Build #20190307.4 succeeded
agogosml-ci (Agogosml-Build-CI) Agogosml-Build-CI succeeded
agogosml-ci (InputReader-Build-CI) InputReader-Build-CI succeeded
agogosml-ci (OutputWriter-Build-CI) OutputWriter-Build-CI succeeded
license/cla All CLA requirements met.

@sayar sayar deleted the remove-null-telemetry-client branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.