Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesFix isort skip of templates directory #294
Conversation
This comment has been minimized.
This comment has been minimized.
sayar
approved these changes
Mar 7, 2019
sayar
merged commit 70fc567
into
master
Mar 7, 2019
sayar
deleted the
fix-isort-skip
branch
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
c-w commentedMar 7, 2019
Looking at the isort source (here and here) it looks like previously we weren't using the isort skip option correctly.