Skip to content

Trigger daily smoke tests after asset publishing#17162

Closed
radical wants to merge 1 commit into
microsoft:mainfrom
radical:radical/smoke-workflow
Closed

Trigger daily smoke tests after asset publishing#17162
radical wants to merge 1 commit into
microsoft:mainfrom
radical:radical/smoke-workflow

Conversation

@radical

@radical radical commented May 16, 2026

Copy link
Copy Markdown
Member

Description

Official AzDO builds publish the assets consumed by the daily and staging CLI install channels, but the CLI smoke workflow was only running on its schedule. This dispatches .github/workflows/tests-daily-smoke.yml after the official build publishes assets so newly published main and release-branch assets get smoke coverage promptly.

This change:

  • Adds a post-asset DispatchDailySmokeTests job in eng/pipelines/azure-pipelines.yml, gated by the shared _PackagesPublished variable.
  • Uses dev quality for main builds and staging quality for release/* and internal/release/* builds.
  • Keeps the AzDO job fire-and-forget by adding -NoWait to the shared GitHub workflow dispatch script.
  • Adds a dispatch correlation ID to the smoke workflow run name so concurrent builds resolve the correct GitHub Actions run URL.
  • Lets AzDO-dispatched smoke failures create issues via the workflow's existing issue-creation job.

Validation:

  • Parsed changed YAML files.
  • Parsed dispatch-release-github-tasks.ps1 with the PowerShell parser.
  • Checked wiring assertions for the published-assets gate, quality selection, fire-and-forget dispatch, run correlation, and failure issue creation.
  • Ran PR polish review; fixed the concurrency correlation issue it found.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Dispatch the daily CLI smoke workflow after the official AzDO build publishes assets, selecting dev quality for main builds and staging quality for release branches.

Add fire-and-forget workflow dispatch support with run-name correlation so concurrent AzDO builds do not resolve the wrong GitHub Actions run.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17162

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17162"

@radical

radical commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

Closing in favor of #17532 .

@radical radical closed this Jun 5, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 13.5 milestone Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants