Fix for Aspire.Deployment.EndToEnd.Tests.AksAzureKubernetesEnvironmentCertManagerTypeScriptDeploymentTests.DeployTypeScriptApiWithCertManagerToAzureKubernetesEnvironment#17432
Closed
mitchdenny wants to merge 1 commit into
Conversation
Since PR #16984 ("Use mts for TypeScript AppHosts") the TypeScript starter template emits apphost.mts instead of apphost.ts. The test was hard-coded to read apphost.ts from the created project, causing an immediate FileNotFoundException right after project creation. Update the file reference (and surrounding doc/log strings) to apphost.mts. Fixes #17427 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17432Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17432" |
Member
Author
|
/deployment-test |
Contributor
|
🚀 Deployment tests starting on PR #17432... This will deploy to real Azure infrastructure. Results will be posted here when complete. |
Contributor
|
❓ CLI E2E Tests unknown — 96 passed, 0 failed, 5 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26350968886 |
Contributor
|
❌ Deployment E2E Tests failed — 37 passed, 3 failed, 0 cancelled View test results and recordings
|
Member
Author
Member
Author
|
Closing in favor of #17434. All three of these auto-filed deployment E2E failures share the same root cause: PR #16984 ("Use mts for TypeScript AppHosts") changed Rather than carry three near-identical PRs through review and CI separately, the fix for this test has been folded into #17434 alongside its sibling ( |
mitchdenny
added a commit
that referenced
this pull request
May 24, 2026
PR #16984 switched TypeScript AppHosts to apphost.mts. Two other deployment E2E tests still referenced apphost.ts and failed with ResourceGroupNotFound for the same reason: - TypeScriptAzureContainerAppJobDeploymentTests: writes its custom AppHost to apphost.mts instead of apphost.ts. - AksAzureKubernetesEnvironmentCertManagerTypeScriptDeploymentTests: patches apphost.mts (the file emitted by the Express/React starter) instead of the no-longer-generated apphost.ts. Supersedes #17432 and #17433. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for
Aspire.Deployment.EndToEnd.Tests.AksAzureKubernetesEnvironmentCertManagerTypeScriptDeploymentTests.DeployTypeScriptApiWithCertManagerToAzureKubernetesEnvironmentFixes #17427
Problem
The test fails immediately after creating the TypeScript Express/React starter
project with:
Root Cause
Since PR #16984 ("Use mts for TypeScript AppHosts") the TypeScript starter
template emits
apphost.mtsinstead ofapphost.ts(seeCliTemplateFactory.TypeScriptStarterTemplate.cs#L75).The test still hard-codes the old
apphost.tsname, soFile.ReadAllTextfails right after project creation.
Fix
Update the test's file reference (and the surrounding XML doc / log strings)
from
apphost.tstoapphost.mts.Verification
CI on this PR will run the standard build. After CI is green, the
/deployment-testcommand will be triggered to re-run the affecteddeployment E2E test against Azure and confirm the fix.