Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "From" email address to email Report task #48

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

fahadash
Copy link

Currently there is no way to specify in the configuration what do you want email's from address to be. It assumes that the SMTP's username is the from address. But for SMTP service connections where username is not an actual email adddress (does not have @ or domain), this tasks fail at runtime.

This PR will Fix #42 by giving user an optional From email configuration field. If skipped, it will defer back to using SMTP's username. This has minimal impact.

@ghost
Copy link

ghost commented Oct 30, 2020

CLA assistant check
All CLA requirements met.

Copy link

@TripleEmcoder TripleEmcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The field was added the same way as other exiting fields.

TripleEmcoder
TripleEmcoder previously approved these changes Aug 26, 2021
@TripleEmcoder
Copy link

Well, I tried, but it seems we need someone with true approving powers :)

@fahadash
Copy link
Author

@TripleEmcoder I appreciate that. Until Microsoft decides to wake up and do something about it, I found a workaround. A powershell script that makes use of System.Net.Smtp to connect to your SMTP server and sends that email.

@TripleEmcoder
Copy link

TripleEmcoder commented Aug 27, 2021

Where do you get the content from? Does the plugin write it somewhere accessible? Could you share the PowerShell script for others to use?

Hopefully someone will get a few notifications now with our activity and find the time to merge the changes.

@fahadash
Copy link
Author

fahadash commented Sep 1, 2021

Where do you get the content from? Does the plugin write it somewhere accessible? Could you share the PowerShell script for others to use?

Hopefully someone will get a few notifications now with our activity and find the time to merge the changes.

@TripleEmcoder Sorry for delayed response here is the script that I wrote

$EmailFrom = no-reply@yourcompany.com
$EmailTo = recipients@yourcompany.com
$Subject = App Deployment Started
$Body = We are taking down the app to deploy the build <a href=`"https://dev.azure.com/Company/projectl/_traceability/runview/changes?currentRunId=$(Build.BuildId)`">$(Build.BuildNumber)</a>, Release $(Release.ReleaseId). 
$SMTPServer = smtp.server.com
$SMTPClient = New-Object Net.Mail.SmtpClient($SmtpServer, 587)
$SMTPClient.EnableSsl = $true
$SMTPClient.Credentials = New-Object System.Net.NetworkCredential("username", "password");
$mail = New-Object System.Net.Mail.Mailmessage $EmailFrom, $EmailTo, $Subject, $Body
$mail.IsBodyHtml = $true

$SMTPClient.Send($mail)

@ksista-ahc
Copy link

ksista-ahc commented Oct 1, 2021

Any idea when this PR can be merged. There is a definite need to fix this extension @fahadash @microsoftopensource

ddeglin
ddeglin previously approved these changes Oct 7, 2021
devops-cafeto
devops-cafeto previously approved these changes Oct 8, 2021
@fahadash fahadash changed the title Add a "From" email address to email Report task Bump: Add a "From" email address to email Report task Oct 20, 2021
@fahadash fahadash changed the title Bump: Add a "From" email address to email Report task Add a "From" email address to email Report task Oct 20, 2021
@xiuzhen1103
Copy link

Any update on this pull request approval?

@ksista-ahc
Copy link

@TripleEmcoder @ddeglin @devops-cafeto Could anyone of you approve the PR and merge it.

@fahadash
Copy link
Author

@saikrishnav Could you merge this PR?

@ksista-ahc
Copy link

@saikrishnav Could you please approve this PR and unblock us... This plugin is a definite need for us

@fahadash
Copy link
Author

@LeahSchwartz Could you help us out? We need these changes merged ASAP to unblock us.

Peadge
Peadge previously approved these changes Dec 3, 2021
@Peadge
Copy link

Peadge commented Dec 3, 2021

@LeahSchwartz or anyone else PLEASE can you approve the changes so this can be merged in, it's the ONLY extension that can email test results out from the Release pipeline.

@fahadash
Copy link
Author

fahadash commented Dec 8, 2021

I have sent an email to opensource@microsoft.com asking for help. Hoping for the best.

@Naweap
Copy link

Naweap commented Jan 14, 2022

Any news on that PR ?

@fahadash
Copy link
Author

I never received a response from Microsoft OpenSource to my email. I am going to try tweeting to their twitter handle, you guys try it too.

@Naweap
Copy link

Naweap commented Jan 14, 2022

I never received a response from Microsoft OpenSource to my email. I am going to try tweeting to their twitter handle, you guys try it too.

Alright, thanks for your answer, it will try it too. However, I don't want to be pessimistic, but it has been almost one year since they didn't release any new version of this extension. By the time this PR is merged and we see this improvement in prod, I think it's gonna take time.

@fahadash fahadash dismissed stale reviews from ddeglin and TripleEmcoder via 8193a4b June 3, 2022 06:05
@fahadash fahadash requested review from Naweap, Peadge and ddeglin and removed request for Naweap and Peadge August 18, 2022 14:29
@dan-hoeger
Copy link

Is there any update on this? we require the ability to specify the "From" address when using an AWS SMTP service.

@asultan80
Copy link

@fahadash Can you remove the review request from @ddeglin ?

@asultan80
Copy link

@saikrishnav Please, take a look and help to resolve this one.
Thank you!

@fahadash
Copy link
Author

fahadash commented Feb 6, 2023

I think we may have to call Microsoft PSS to get their attention into this.

@fahadash
Copy link
Author

fahadash commented Feb 7, 2023

@ddeglin This PR is waiting on you again, could you look into this please?

@fahadash
Copy link
Author

@saikrishnav Could you merge this PR please?

@ZaafirDar
Copy link

@fahadash Can we please get this PR merged, still running into this problem.

@fahadash
Copy link
Author

Looks like we have lost @ddeglin , I am going to convert this to draft, that is probably going to remove the existing approvals.

@fahadash fahadash marked this pull request as draft September 19, 2023 15:56
@fahadash fahadash marked this pull request as ready for review September 19, 2023 18:07
@fahadash
Copy link
Author

It turns out that we have to wait for a Build to occur before this PR can be merged.

@ZaafirDar
Copy link

@fahadash Any Idea how is build triggered? Should we expect any response on this?

@fahadash
Copy link
Author

@saikrishnav Could you get the build 10.x check taken care of?

@ZaafirDar
Copy link

@saikrishnav can you help us with build (10.x) Check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E-Mail "From" field is not available