From 786f14a00fbd4189662ca68094547231c95f7820 Mon Sep 17 00:00:00 2001 From: Konstantin Tyukalov Date: Tue, 21 Feb 2023 17:57:31 +0400 Subject: [PATCH 1/2] Remove note about v4 task lib status --- CONTRIBUTING.md | 8 -------- 1 file changed, 8 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 515a6bd54..697ac31f5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,13 +1,5 @@ # Instructions for Contributing Code -## Current status - -Since at the moment work is proceeding on migrating to Node16, you need to remember the following: - -- master branch for SDK v3 (stable and targets Node10) -- releases/4.x branch for SDK v4 (preview and targets Node16) -- Changes that were merged for SDK v3 should be cherry-picked for SDK v4 once they are merged to the master branch - ## Contributing bug fixes We are currently accepting contributions in the form of bug fixes. A bug must have an issue tracking it in the issue tracker. Your pull request should include a link to the bug that you are fixing. If you've submitted a PR for a bug, please post a comment in the bug to avoid duplication of effort. From b3b7e6122fcc691b0a9ee9a9d14ef806e9ce0834 Mon Sep 17 00:00:00 2001 From: Konstantin Tyukalov Date: Tue, 21 Feb 2023 18:01:40 +0400 Subject: [PATCH 2/2] Fix formatting --- CONTRIBUTING.md | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 697ac31f5..0f3481b6a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -14,21 +14,20 @@ Design changes will not be accepted at this time. If you have a design change pr You will need to complete a Contributor License Agreement (CLA). Briefly, this agreement testifies that you are granting us permission to use the submitted change according to the terms of the project's license, and that the work being submitted is under appropriate copyright. -Please submit a Contributor License Agreement (CLA) before submitting a pull request. You may visit https://cla.microsoft.com to sign digitally. +Please submit a Contributor License Agreement (CLA) before submitting a pull request. You may visit to sign digitally. ## Housekeeping -Your pull request should: +Your pull request should: * Include a description of what your change intends to do -* Be a child commit of a reasonably recent commit in the **master** branch - * Requests need not be a single commit, but should be a linear sequence of commits (i.e. no merge commits in your PR) +* Be a child commit of a reasonably recent commit in the **master** branch + * Requests need not be a single commit, but should be a linear sequence of commits (i.e. no merge commits in your PR) * It is desirable, but not necessary, for the tests to pass at each commit -* Have clear commit messages - * e.g. "Refactor feature", "Fix issue", "Add tests for issue" -* Include adequate tests - * At least one test should fail in the absence of your non-test code changes. If your PR does not match this criteria, please specify why - * Tests should include reasonable permutations of the target fix/change - * Include baseline changes with your change - * All changed code must have 100% code coverage - +* Have clear commit messages + * e.g. "Refactor feature", "Fix issue", "Add tests for issue" +* Include adequate tests + * At least one test should fail in the absence of your non-test code changes. If your PR does not match this criteria, please specify why + * Tests should include reasonable permutations of the target fix/change + * Include baseline changes with your change + * All changed code must have 100% code coverage