Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for helm 3 #11735

Merged
merged 5 commits into from Nov 14, 2019
Merged

add support for helm 3 #11735

merged 5 commits into from Nov 14, 2019

Conversation

jldeen
Copy link
Member

@jldeen jldeen commented Nov 12, 2019

Resolves issue #11316 and adds support for Helm 3

Helm 3 removes Tiller and thus removes the "init" command and "--client-only" flag. This is a blocker for those who are prepping to use Helm 3 (currently in RC3 phase).

This PR adds a check for Helm 2. If Helm 2 is specified, helmTool.arg is set with init and --client-only but if helm version specified does not start with "2" then helmTool.arg will run version instead (best way to check helm 3 usage)

@vithati vithati requested a review from Anumita Nov 13, 2019
@mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Nov 13, 2019

FYI: Helm 3.0.0 has just been released officially: https://helm.sh/blog/helm-3-released/ So yep, we need this fix for sure! ;)

@jldeen
Copy link
Member Author

@jldeen jldeen commented Nov 13, 2019

@mathieu-benoit I work for Microsoft and I pinged the team internally, too. Hopefully this gets reviewed and merged ASAP.

bump patch version for PR #11735
@jldeen jldeen requested a review from vithati as a code owner Nov 14, 2019
bump patch version for PR #11735
Copy link
Contributor

@shashankbarsin shashankbarsin left a comment

LGTM

@shashankbarsin shashankbarsin merged commit 044ad67 into microsoft:master Nov 14, 2019
8 checks passed
@azooinmyluggage
Copy link
Contributor

@azooinmyluggage azooinmyluggage commented Nov 15, 2019

LGTM

leantk pushed a commit that referenced this issue Dec 23, 2019
bump patch version for PR #11735
leantk pushed a commit that referenced this issue Dec 23, 2019
bump patch version for PR #11735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants