Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook crashes on large data #6543

Closed
rohailiqbal opened this issue Jul 31, 2019 · 2 comments

Comments

@rohailiqbal
Copy link

commented Jul 31, 2019

Issue Type: Bug

SQL Server
I have large database with millions of record in many tables.

  1. click +Code
  2. select * from table1
    it will show top 5000 rows
  3. Click +text
    type something (Azure Data Studio will start pausing and late response)
  4. Click +Code
  5. select * from table2
    it will try loading data... keeps on trying and crashes

Azure Data Studio version: azuredatastudio 1.9.0 (78a42e1, 2019-07-10T04:31:36.998Z)
OS version: Windows_NT x64 6.1.7601

System Info
Item Value
CPUs Intel(R) Core(TM) i5-4570 CPU @ 3.20GHz (4 x 3192)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.91GB (5.05GB free)
Process Argv
Screen Reader no
VM 0%
Extensions: none
@chlafreniere

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

Thanks, @rohailiqbal. It may be related to #6392 but let's keep this open for now in case the culprit is different.

@chlafreniere

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

We've spent some significant effort improving memory usage/performance for notebooks in the September release (current efforts can be seen in insiders). I tested a large (~60MB) notebook on both with the August (1.10) release and our current insiders release. Here's the difference:

August:
image

Insiders [i.e. September release soon]:
image

If you end up seeing any issues in the future with this, I would love to hear about it, as the team put significant effort into minimizing any crashes as much as posible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.