Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments cause strange behavior in PowerShell notebooks with functions #9018

Closed
BobPusateri opened this issue Jan 31, 2020 · 6 comments
Closed

Comments cause strange behavior in PowerShell notebooks with functions #9018

BobPusateri opened this issue Jan 31, 2020 · 6 comments

Comments

@BobPusateri
Copy link

@BobPusateri BobPusateri commented Jan 31, 2020

  • Azure Data Studio Version:
    Version: 1.15.0-insider (user setup)
    Commit: 7d751a2
    Date: 2020-01-31T18:42:04.788Z
    VS Code: 1.42.0
    Electron: 6.1.6
    Chrome: 76.0.3809.146
    Node.js: 12.4.0
    V8: 7.6.303.31-electron.0
    OS: Windows_NT x64 10.0.18362

  • Steps to Reproduce:

Create a PowerShell notebook with a cell containing one or more functions. At the end of each function, either on the same line as the closing bracket or on the line following that, add a comment.

When running the cell to define the function(s) so they can be called in subsequent cells, the cell will never complete - it just keeps running.

Removing the comments, or placing them in multi-line comment format, causes the cell to execute properly.

I have created a PowerShell notebook to demonstrate this.

@SQLDBAWithABeard

This comment has been minimized.

Copy link

@SQLDBAWithABeard SQLDBAWithABeard commented Feb 1, 2020

Yup, it's a very strange one and I confirm that I have the same behaviour on my machine as well

@chlafreniere

This comment has been minimized.

Copy link
Contributor

@chlafreniere chlafreniere commented Feb 1, 2020

Which version of the powershell-kernel python package is installed on your machines?

The Manage Packages button on the notebook toolbar will take you to a dialog that lists all of the packages and their versions.

0.1.3 is the latest.

@chlafreniere

This comment has been minimized.

Copy link
Contributor

@chlafreniere chlafreniere commented Feb 1, 2020

On the off chance that you're both on an older version of the PS package, I created another bug (and its corresponding PR) to track ensuring that we prompt users to install the newest version of the Powershell kernel. #9023

@BobPusateri

This comment has been minimized.

Copy link
Author

@BobPusateri BobPusateri commented Feb 2, 2020

@chlafreniere I believe that was exactly the issue! I was running 0.1.2. As soon as I upgraded to 0.1.3, that demo notebook behaved exactly as expected. Thank you so much for pointing that out and taking care of this!

@SQLDBAWithABeard

This comment has been minimized.

Copy link

@SQLDBAWithABeard SQLDBAWithABeard commented Feb 3, 2020

Also confirm that this has resolved the issue.

When was this new package released? I was testing on a brand new deployed win 10 machine that a client had given me where I installed ADS only last week and I had version 0.1.2

Where is this information? and can it be surfaced in a public manner ?

I agree that #9023 will provide a prompt and that is a good thing but it will also be good for those of us who inform and educate people to know as this would help to resolve issues quicker (speaking as someone who gladly receives many questions about PowerShell notebooks :-) )

@corivera

This comment has been minimized.

Copy link
Member

@corivera corivera commented Feb 3, 2020

Closing this one since it's related to #9022

@corivera corivera closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.