Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect query plan when select XML showplan in the result grid #967

Closed
AbbiePetcht opened this issue Mar 23, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@AbbiePetcht
Copy link
Contributor

commented Mar 23, 2018

Select XML showplan in the result, should open query plan

Scenario: It is the main scenario for execute sp_whoisactive to get plans

  1. connect to server that have sp_whoisactive (sqltools2017-3)
  2. EXEC sp_WhoIsActive
    @get_plans = 1

Actual result:
It opens up new xml editor file.

Expect result:
It should open query plan

Simple repro step:

  1. open editor and run "select * from sys.tables"
  2. select "explain"
  3. go to result grid and select the showplan link

@AbbiePetcht AbbiePetcht added Area: Query Plan Bug and removed Bug labels Mar 23, 2018

@anthonydresser

This comment has been minimized.

Copy link
Member

commented Mar 23, 2018

This might be difficult considering it's just another xml that is the format of a showplan, We would need to be able to parse it and test it for showplan, which i'm not sure its worth it, when a user can click showplan for a query. Before we had a feature that if you selected showplan as the language type rather than xml it would show the plan in the editor? @kburtram I remember this being demoed after the "hackathon" we had, not sure if it's still in the product.

@StevenHibble

This comment has been minimized.

Copy link

commented Mar 28, 2018

I run sp_whoisactive with @get_plans = 1 a lot in SSMS. It helps me tune my end users' queries in real time. Now that the whoisactive extension is live (and explicitly has a "Get plans" button), I'd appreciate this support.

It seems that SSMS's implementation involves:

  1. Recognize it's an execution plan
  2. Save the XML as a .sqlplan file somewhere
  3. Open that file

@AbbiePetcht AbbiePetcht self-assigned this Apr 6, 2018

@adsbot adsbot bot locked and limited conversation to collaborators Mar 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.